Skip to content

Conversation

@kou
Copy link
Member

@kou kou commented Jun 1, 2017

No description provided.

Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, though the macOS build took 32 minutes. Do you have any insight as to why so long?

@kou kou force-pushed the glib-travis-macos branch 2 times, most recently from 03ff410 to 1c45cdd Compare June 3, 2017 03:16
Because it's tested on Linux and Torch install is slow.
@kou kou force-pushed the glib-travis-macos branch from 1c45cdd to 1a08aa0 Compare June 3, 2017 03:45
@kou
Copy link
Member Author

kou commented Jun 3, 2017

Installing Torch takes a long time. So I disabled running a Torch example on macOS. It's already ran on Linux. We don't need to run it on macOS.

@asfgit asfgit closed this in a81aefb Jun 3, 2017
@wesm
Copy link
Member

wesm commented Jun 3, 2017

Sounds good, thanks!

@kou kou deleted the glib-travis-macos branch June 4, 2017 05:01
pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
…apache#722)

## What's Changed

Allow actually reaching MAX_BUFFER_SIZE at reallocating variable width
vectors instead of exceeding it calculating the next power of 2.
For unit testing the maximum allocation size has be increased to 2MB -
1byte to simulate the default maximum behavior. Due to this change
needed some updates in existing unit tests because of the round ups used
at calculating the required buffer sizes.

Closes apache#721.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants