ARROW-1080: C++: Add tutorial about converting to/from row-wise representation #721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @pacman82 |
BryanCutler
reviewed
Jun 1, 2017
Member
BryanCutler
left a comment
BryanCutler
left a comment
There was a problem hiding this comment.
Thanks for doing this, it looks great! I just had that one minor question, otherwise LGTM
| auto costs = std::static_pointer_cast<arrow::DoubleArray( | ||
| table->column(1)->data()->chunk(1)); | ||
| auto cost_components = std::static_pointer_cast<arrow::ListArray( | ||
| table->column(2)->data()->chunk(2)); |
Member
There was a problem hiding this comment.
Should this and the above be ->chunk(0)?
Contributor
|
@xhochy are you open to suggestions about grammar / wording on this change? |
Member
Author
|
@jeffknupp As I'm not a native English speaker, I'm very grateful for that ;) |
Change-Id: I7284498c3d5ba1da4da257d5341fd2a3d7023a3d
Member
|
I think it's fine to submit follow up patches to expand or improve this part of the docs |
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
…apache#722) ## What's Changed Allow actually reaching MAX_BUFFER_SIZE at reallocating variable width vectors instead of exceeding it calculating the next power of 2. For unit testing the maximum allocation size has be increased to 2MB - 1byte to simulate the default maximum behavior. Due to this change needed some updates in existing unit tests because of the round ups used at calculating the required buffer sizes. Closes apache#721.
timhurskidremio
added a commit
to timhurskidremio/dremio-arrow
that referenced
this pull request
Nov 3, 2025
timhurskidremio
added a commit
to dremio/arrow
that referenced
this pull request
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.