MINOR: Test CI #925
Open
MINOR: Test CI #925
+0
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Member
Author
Member
|
Could you try this for JNI on macOS? We need diff --git a/.github/workflows/rc.yml b/.github/workflows/rc.yml
index efa69533..83235d2c 100644
--- a/.github/workflows/rc.yml
+++ b/.github/workflows/rc.yml
@@ -259,11 +259,6 @@ jobs:
brew uninstall grpc || : # gRPC depends on RE2
brew uninstall [email protected] || : # gRPC 1.54 may be installed too
brew uninstall re2
- # We want to use bundled Protobuf for static linking. If
- # Homebrew's Protobuf is installed, its library file may be
- # used on test We uninstall Homebrew's Protobuf to ensure using
- # bundled Protobuf.
- brew uninstall protobuf
brew bundle --file=Brewfile
- name: Prepare ccache
diff --git a/gandiva/CMakeLists.txt b/gandiva/CMakeLists.txt
index 369829d7..d75cbe28 100644
--- a/gandiva/CMakeLists.txt
+++ b/gandiva/CMakeLists.txt
@@ -57,7 +57,6 @@ set_property(TARGET arrow_java_jni_gandiva PROPERTY OUTPUT_NAME "gandiva_jni")
target_link_libraries(arrow_java_jni_gandiva
arrow_java_jni_gandiva_headers
jni
- protobuf::libprotobuf
Gandiva::gandiva_static)
# Localize thirdparty symbols using a linker version script. This hides themOr can we remove Protobuf dependency from https://github.com/apache/arrow-java/tree/main/gandiva ...? It will simplify our build system... |
Member
|
Could you try apache/arrow#48726 for JNI on Windows? diff --git a/.github/workflows/rc.yml b/.github/workflows/rc.yml
index efa69533d..fc8238717 100644
--- a/.github/workflows/rc.yml
+++ b/.github/workflows/rc.yml
@@ -324,7 +324,8 @@ jobs:
# if: github.event_name == 'schedule'
uses: actions/checkout@v6
with:
- repository: apache/arrow
+ repository: kou/arrow
+ ref: cpp-bundled-protobuf
path: arrow
- name: Set up Java
uses: actions/setup-java@v5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just an empty commit to test the CI (again) and stabilize.