fix: gets rid of node engine >= 17 requirement #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpinho
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
A breaking change was introduced on this PR#294, causing everyone that depends on versions above 9.0.9 to now have to update their node engines to >= v17.
There is also an open issue on the
json-schema-ref-parserrepo regarding this same problem issue#298.Change
This PR, removed the node engine limitation and gets rid of a node17 specific flag.
Tests
All tests pass locally on MacOS 13 (Ventura); not sure about other environments. Either way, the only reason the engine was updated was due to some browser test, and since the
json-schema-ref-parserCI points to Node 17, the tests should keep passing on their pipelines. The node engine requirement was just nonsense.