Breaking change in patch version 9.1.0 -> 9.1.1

[monkpit]

If possible it would be great if version 9.1.1 could be unpublished from npm, as it contains a breaking change (node engine) and is not backward-compatible with other 9.x versions.

Our code with a subdependency on version ^9.0.9 recently started to fail due to this issue.

[viper707]

@philsturgeon did you mean to check in:
"engines": { "node": ">= 17" },

to version 9.1.1? I see your disclaimer on version 10. Maybe these lines were meant for version 10?

[khevamann]

Also causing issues here!

[danielsalles]

Same

[mikeharder]

The title is slightly incorrect. The breaking change was introduced between 9.1.0 and 9.1.1 (a patch version rather than a minor version).

[jcmosc]

Hey I wrote the PR that broke this. It hadn't hit me that it would autorelease a patch version upon merge since I didn't annotate the relevant commit message as a breaking change.

Suggest pinning to the exact version 9.1.0 if you haven't already, until a 9.1.2 can be released.

Sorry about this!

[mikeharder]

@jamesmoschou: Can you unpublish or deprecate 9.1.1? This might be faster and easier than releasing a 9.1.2, and would fix packages depending on ^9.0.0.

[jcmosc]

@mikeharder I'm not a maintainer, just an external contributor

[rcb4t2]

We're having problems from this too, it's breaking https://github.com/firebase/firebase-tools on our Node 14 CI system

Please roll back as soon as possible, thank you!

@philsturgeon

[monkpit]

Hey I wrote the PR that broke this. It hadn't hit me that it would autorelease a patch version upon merge since I didn't annotate the relevant commit message as a breaking change.

Suggest pinning to the exact version 9.1.0 if you haven't already, until a 9.1.2 can be released.

Sorry about this!

For our use case, we can’t pin the dependency because it’s a dependency of another dependency, and we are consuming it in a package within our own private NPM registry, so lock files are not honored when the package is installed (which is how npm/yarn work).

[emrysal]

@monkpit (and others) you can resolve sub dependencies to a desired version with package.json resolutions.

"resolutions": {
    "@apidevtools/json-schema-ref-parser": "9.1.0",
    ...
},

[khevamann]

@emrysal firebase-tools is installed as a global package. I'm not sure there is a way to add resolutions for that. Especially through CI runners like GitHub actions

[monkpit]

@monkpit (and others) you can resolve sub dependencies to a desired version with package.json resolutions.

"resolutions": {
    "@apidevtools/json-schema-ref-parser": "9.1.0",
    ...
},

This does not appear to work in cases when the consumer of the dependency is a package as opposed to a project with a lockfile (we tried).