Skip to content

Add design points and modify named selection #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 59 commits into from
Apr 10, 2023
Merged

Add design points and modify named selection #219

merged 59 commits into from
Apr 10, 2023

Conversation

@Revathyvenugopal162
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented Nov 7, 2022 •
edited
Loading

@Revathyvenugopal162 Revathyvenugopal162 added the enhancement New features or code improvements label Nov 7, 2022
@Revathyvenugopal162 Revathyvenugopal162 self-assigned this Nov 7, 2022
RobPasMue
RobPasMue reviewed Nov 7, 2022
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Implement changes and request review again

@Revathyvenugopal162 Revathyvenugopal162 marked this pull request as ready for review November 7, 2022 13:24
MaxJPRey
MaxJPRey reviewed Nov 7, 2022
View reviewed changes
MaxJPRey
MaxJPRey reviewed Nov 7, 2022
View reviewed changes
MaxJPRey
MaxJPRey reviewed Nov 7, 2022
View reviewed changes
MaxJPRey
MaxJPRey reviewed Nov 7, 2022
View reviewed changes
RobPasMue
RobPasMue reviewed Nov 7, 2022
View reviewed changes
chadqueen
chadqueen previously approved these changes Nov 7, 2022
View reviewed changes
@chadqueen
Copy link
Contributor

chadqueen commented Nov 7, 2022

thanks @Revathyvenugopal162 , nice work on these implementations

@RobPasMue
Copy link
Member

RobPasMue commented Nov 7, 2022

We still have the issue with the container here... as with #207 - we can't merge this PR until the container issues are resolved.

Solve the __repr__ method comment and we will leave it approved and pending container update @Revathyvenugopal162 =)

RobPasMue
RobPasMue previously approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RobPasMue
Copy link
Member

RobPasMue commented Feb 1, 2023

Let me retake this issue... Let's see if we can solve it.

@RobPasMue RobPasMue added the SERVER-IMPLEMENTATION Issue/PR assigned with this tag must be solved server-side label Feb 1, 2023
@RobPasMue RobPasMue dismissed stale reviews from chadqueen and themself via 36f5906 February 20, 2023 17:21
@RobPasMue RobPasMue requested a review from jonahrb as a code owner February 21, 2023 14:58
@RobPasMue RobPasMue linked an issue Apr 10, 2023 that may be closed by this pull request
Crashing functionalities server side after Beam creation calls #203
Closed
RobPasMue
RobPasMue reviewed Apr 10, 2023
View reviewed changes
RobPasMue
RobPasMue approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And we can finally merge this!!

@RobPasMue RobPasMue enabled auto-merge (squash) April 10, 2023 07:59
@RobPasMue RobPasMue merged commit bd7bf01 into main Apr 10, 2023
@RobPasMue RobPasMue deleted the feat/add-design-points-and-modify-named-selection branch April 10, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaxJPRey MaxJPRey MaxJPRey left review comments

@RobPasMue RobPasMue RobPasMue approved these changes

@jonahrb jonahrb Awaiting requested review from jonahrb

+1 more reviewer

@chadqueen chadqueen chadqueen left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Revathyvenugopal162 Revathyvenugopal162

Labels

enhancement New features or code improvements SERVER-IMPLEMENTATION Issue/PR assigned with this tag must be solved server-side

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Include DesignPoint APIs Adapt NamedSelections to also accept Beams and DesignPoints Crashing functionalities server side after Beam creation calls

5 participants

@Revathyvenugopal162 @chadqueen @RobPasMue @MaxJPRey