Skip to content

Conversation

@RobPasMue
Copy link
Member

Solves #198

@RobPasMue RobPasMue self-assigned this Oct 27, 2022
@RobPasMue RobPasMue linked an issue Oct 27, 2022 that may be closed by this pull request
@github-actions github-actions bot added the enhancement New features or code improvements label Oct 27, 2022
@RobPasMue
Copy link
Member Author

Might need some help debugging here @chadqueen. Looks like we can't delete beams for some reason... Up for a pair-programming session? I'd like to learn how to debug inside the container if possible - and its implications (SW needed etc)

@chadqueen
Copy link
Contributor

Might need some help debugging here @chadqueen. Looks like we can't delete beams for some reason... Up for a pair-programming session? I'd like to learn how to debug inside the container if possible - and its implications (SW needed etc)

After our last meeting where using the body delete was mentioned, Jonah said he did not think the bodies delete request to work for a beam. He said he would add a new endpoint.

@RobPasMue
Copy link
Member Author

RobPasMue commented Oct 27, 2022

Might need some help debugging here @chadqueen. Looks like we can't delete beams for some reason... Up for a pair-programming session? I'd like to learn how to debug inside the container if possible - and its implications (SW needed etc)

After our last meeting where using the body delete was mentioned, Jonah said he did not think the bodies delete request to work for a beam. He said he would add a new endpoint.

Well, he must have said it somewhere else but not in the meeting.... Otherwise I wouldn't have implemented it 😄

@RobPasMue
Copy link
Member Author

This branch will remain stale until implemented server side.

@github-actions github-actions bot added the maintenance Package and maintenance related label Oct 28, 2022
@RobPasMue
Copy link
Member Author

RobPasMue commented Oct 28, 2022

PR pending on:

  • New protos package release
  • New docker container release
  • Ensuring everything works properly

chadqueen
chadqueen previously approved these changes Nov 4, 2022
@RobPasMue RobPasMue added the SERVER-IMPLEMENTATION Issue/PR assigned with this tag must be solved server-side label Feb 1, 2023
@RobPasMue RobPasMue requested a review from jonahrb as a code owner February 21, 2023 14:58
@RobPasMue RobPasMue merged commit 044b6a6 into main Apr 10, 2023
@RobPasMue RobPasMue deleted the feat/delete-beam branch April 10, 2023 07:09
@RobPasMue RobPasMue linked an issue Apr 10, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements maintenance Package and maintenance related SERVER-IMPLEMENTATION Issue/PR assigned with this tag must be solved server-side

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crashing functionalities server side after Beam creation calls Implement Beam deletion functionalities

3 participants