-
Notifications
You must be signed in to change notification settings - Fork 20
test: Expand code coverage and fix a few things #2039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2039 +/- ##
==========================================
+ Coverage 90.50% 91.57% +1.06%
==========================================
Files 136 136
Lines 9787 9769 -18
==========================================
+ Hits 8858 8946 +88
+ Misses 929 823 -106 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments regarding on location for the tests. Other than that, LGTM! Request another review once you resolve the comments.
…s/pyansys-geometry into test/expand_code_coverage_1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @RyanJWard
Description
Expanded test coverage found by pytest
Checklist
feat: extrude circle to cylinder
)