Skip to content

Conversation

RyanJWard
Copy link
Contributor

@RyanJWard RyanJWard commented Jun 11, 2025

Description

Expanded test coverage found by pytest

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RyanJWard RyanJWard self-assigned this Jun 11, 2025
@RyanJWard RyanJWard requested a review from a team as a code owner June 11, 2025 19:28
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.57%. Comparing base (9859054) to head (90111ad).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2039      +/-   ##
==========================================
+ Coverage   90.50%   91.57%   +1.06%     
==========================================
  Files         136      136              
  Lines        9787     9769      -18     
==========================================
+ Hits         8858     8946      +88     
+ Misses        929      823     -106     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments regarding on location for the tests. Other than that, LGTM! Request another review once you resolve the comments.

@github-actions github-actions bot added the testing Anything related to tests label Jun 12, 2025
@RyanJWard RyanJWard requested a review from RobPasMue June 12, 2025 11:23
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @RyanJWard

@RyanJWard RyanJWard merged commit 7defdf3 into main Jun 12, 2025
44 checks passed
@RyanJWard RyanJWard deleted the test/expand_code_coverage_1 branch June 12, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Anything related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants