test: Expand code coverage and fix a few things (#2039)

Co-authored-by: pyansys-ci-bot <[email protected]>

Author: RyanJWard

doc/changelog.d/2039.test.md

@@ -0,0 +1 @@
+Expand code coverage and fix a few things

src/ansys/geometry/core/shapes/box_uv.py

@@ -93,22 +93,14 @@ def get_center(self) -> ParamUV:
 
     def is_negative(self, tolerance_u: Real, tolerance_v: Real) -> bool:
         """Check whether the BoxUV is negative."""
-        if self.is_empty():
-            return False
         return self.interval_u.is_negative(tolerance_u) or self.interval_v.is_negative(tolerance_v)
 
     def contains(self, param: ParamUV) -> bool:
         """Check whether the BoxUV contains a given u and v pair parameter."""
-        if self.is_empty():
-            # Cannot check contains for an empty box uv.
-            raise RuntimeError("Cannot check contains for an empty box uv.")
         return self.interval_u.contains(param.u) and self.interval_v.contains(param.v)
 
     def inflate(self, delta_u: Real, delta_v: Real) -> "BoxUV":
         """Enlarge the BoxUV u and v intervals by deltas."""
-        if self.is_empty():
-            # Cannot inflate an empty box uv.
-            raise RuntimeError("Cannot inflate an empty box uv.")
         return BoxUV(self.interval_u.inflate(delta_u), self.interval_v.inflate(delta_v))
 
     def get_corner(self, location: LocationUV) -> ParamUV:

src/ansys/geometry/core/shapes/parameterization.py

@@ -150,7 +150,7 @@ class Interval:
     @check_input_types
     def __init__(self, start: Real, end: Real) -> None:
         """Initialize ``Interval`` class."""
-        if end < start:
+        if end <= start:
             raise ValueError("Start value must be less than end value")
 
         self._start = start
@@ -172,9 +172,6 @@ def __eq__(self, other: object):
         if not isinstance(other, Interval):
             # don't attempt to compare against unrelated types
             return NotImplemented
-        if self.is_empty() or other.is_empty():
-            return self.is_empty() and other.is_empty()
-
         return Accuracy.equal_doubles(self.start, other.start) and Accuracy.equal_doubles(
             self.end, other.end
         )
@@ -270,10 +267,6 @@ def unite(first: "Interval", second: "Interval") -> "Interval":
         Interval
             Union of the two intervals.
         """
-        if first.is_empty():
-            return second
-        if second.is_empty():
-            return first
         return Interval(min(first.start, second.start), max(first.end, second.end))
 
     def self_unite(self, other: "Interval") -> None:
@@ -302,10 +295,8 @@ def intersect(first: "Interval", second: "Interval", tolerance: Real) -> "Interv
         Interval
             Intersection of the two intervals.
         """
-        if first.is_empty() or second.is_empty():
-            return None  # supposed to be empty
-        intersection = Interval(max(first.start, second.start), min(first.end, second.send))
-        if not intersection.is_negative(tolerance):
+        intersection = Interval(max(first.start, second.start), min(first.end, second.end))
+        if intersection.is_negative(tolerance) == 1:
             return intersection
         return None  # supposed to be empty
 
@@ -336,8 +327,6 @@ def contains_value(self, t: Real, accuracy: Real) -> bool:
         bool
             ``True`` if the interval contains the value, ``False`` otherwise.
         """
-        if self.is_empty():
-            return False
         negative_abs_accuracy = -abs(accuracy)
         if self.start > self.end:
             if self.start - t < negative_abs_accuracy:
@@ -368,9 +357,6 @@ def contains(self, t: Real) -> bool:
 
     def inflate(self, delta: Real) -> "Interval":
         """Enlarge the current interval by the given delta value."""
-        if self.is_empty():
-            # throw Error.InvalidMethodOnEmptyObjectException(GetType())
-            raise Exception("Invalid Method On Empty Object Exception" + type(self).__name__)
         return Interval(self.start - delta, self.end + delta)
 
     def __repr__(self) -> str:

tests/integration/test_design.py

@@ -61,13 +61,15 @@
     Cone,
     Cylinder,
     Ellipse,
-    Interval,
     Line,
     ParamUV,
     Sphere,
     Torus,
 )
 from ansys.geometry.core.shapes.box_uv import BoxUV
+from ansys.geometry.core.shapes.parameterization import (
+    Interval,
+)
 from ansys.geometry.core.sketch import Sketch
 
 from ..conftest import are_graphics_available

tests/integration/test_trimmed_geometry.py

@@ -22,6 +22,7 @@
 """Tests trimmed geometry."""
 
 import numpy as np
+from pint import Quantity
 import pytest
 
 from ansys.api.geometry.v0.commands_pb2 import CreateSketchLineRequest
@@ -30,6 +31,7 @@
 from ansys.geometry.core.designer.face import SurfaceType
 from ansys.geometry.core.math import Point3D, UnitVector3D
 from ansys.geometry.core.math.point import Point2D
+from ansys.geometry.core.misc import UNITS
 from ansys.geometry.core.modeler import Modeler
 from ansys.geometry.core.shapes import Circle, Line
 from ansys.geometry.core.shapes.box_uv import LocationUV
@@ -304,3 +306,48 @@ def test_trimmed_curve_circle_rotate(hedgehog_design):
 
     assert np.allclose(trimmed_curve.start, Point3D([0.01, 0.01, 0.02]))
     assert np.allclose(trimmed_curve.end, Point3D([0.01, 0.01, 0.04]))
+
+
+def test_trimmed_curve(modeler: Modeler):
+    """Test Trimmed Curve class"""
+    design = modeler.create_design("trimmed_curve_edges")
+    body = design.extrude_sketch("box", Sketch().box(Point2D([0, 0]), 1, 1), 1)
+    with pytest.raises(ValueError):
+        design.bodies[0].edges[0].shape.intersect_curve(design.bodies[0].edges[1].shape)
+    # Retrieve edges and initialize TrimmedCurve objects with the gRPC client
+    edge0 = TrimmedCurve(
+        geometry=body.edges[0].shape.geometry,
+        start=body.edges[0].shape.start,
+        end=body.edges[0].shape.end,
+        interval=body.edges[0].shape.interval,
+        length=body.edges[0].shape.length,
+        grpc_client=modeler.client,  # Pass the gRPC client here
+    )
+    edge1 = TrimmedCurve(
+        geometry=body.edges[1].shape.geometry,
+        start=body.edges[1].shape.start,
+        end=body.edges[1].shape.end,
+        interval=body.edges[1].shape.interval,
+        length=body.edges[1].shape.length,
+        grpc_client=modeler.client,  # Pass the gRPC client here
+    )
+
+    edge2 = TrimmedCurve(
+        geometry=body.edges[4].shape.geometry,
+        start=body.edges[4].shape.start,
+        end=body.edges[4].shape.end,
+        interval=body.edges[4].shape.interval,
+        length=body.edges[4].shape.length,
+        grpc_client=modeler.client,  # Pass the gRPC client here
+    )
+
+    # Perform assertions and call intersect_curve
+    assert (
+        edge0.__repr__()
+        == "TrimmedCurve(geometry: <class 'ansys.geometry.core.shapes.curves.line.Line'>, "
+        "start: [-0.5 -0.5  1. ], end: [ 0.5 -0.5  1. ], "
+        "interval: Interval(start=0.0, end=1.0), length: 1.0 meter)"
+    )
+    assert edge0.length == Quantity(1, UNITS.m)
+    assert edge0.intersect_curve(edge1) == [Point3D([-0.5, -0.5, 1.0])]
+    assert edge0.intersect_curve(edge2) == []

tests/test_parameterization.py

@@ -131,3 +131,31 @@ def test_parameterization():
 
     with pytest.raises(BeartypeCallHintParamViolation):
         Parameterization(ParamForm.CLOSED, ParamType.OTHER, [-1, 1])
+
+
+def test_param_uv_iter():
+    """Test the __iter__ method of ParamUV."""
+    param = ParamUV(3.5, 7.2)
+    u, v = param  # Unpack using the __iter__ method
+    assert u == 3.5
+    assert v == 7.2
+
+
+def test_param_uv_repr():
+    """Test the __repr__ method of ParamUV."""
+    param = ParamUV(3.5, 7.2)
+    assert repr(param) == "ParamUV(u=3.5, v=7.2)"
+
+
+def test_parameterization_repr():
+    """Test the __repr__ method of the Parameterization class."""
+    # Create a sample Parameterization object
+    interval = Interval(0, 10)
+    parameterization = Parameterization(ParamForm.CLOSED, ParamType.LINEAR, interval)
+    # Expected string representation
+    expected_repr = (
+        "Parameterization(form=ParamForm.CLOSED, type=ParamType.LINEAR, "
+        "interval=Interval(start=0, end=10))"
+    )
+    # Assert the __repr__ output matches the expected string
+    assert repr(parameterization) == expected_repr