-
Couldn't load subscription status.
- Fork 22
fix: GetSurface and GetCurve not available prior to 24R2 #1171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just those two minor comments
|
I believe the comments don't apply @AlejandroFernandezLuces - please review my answers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from @AlejandroFernandezLuces 's comment it looks good to me. Thanks @RobPasMue
|
Thank you both for your reviews! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1171 +/- ##
=======================================
Coverage 90.56% 90.57%
=======================================
Files 93 93
Lines 6987 6993 +6
=======================================
+ Hits 6328 6334 +6
Misses 659 659 ☔ View full report in Codecov by Sentry. |
…ys-geometry into fix/get-surface-24r1
f289216
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is better handled with the semver package, nice addition 🙂
Co-authored-by: Kathy Pippert <[email protected]>
Description
Fixing 24R1 related issue due to GetSurface and GetCurve APIs
Issue linked
Closes #1170
Checklist
feat: extrude circle to cylinder)