Skip to content

Conversation

@RobPasMue
Copy link
Member

@RobPasMue RobPasMue commented Apr 26, 2024

Description

Fixing 24R1 related issue due to GetSurface and GetCurve APIs

Issue linked

Closes #1170

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Apr 26, 2024
@RobPasMue RobPasMue requested a review from a team as a code owner April 26, 2024 13:57
@github-actions github-actions bot added maintenance Package and maintenance related bug Something isn't working labels Apr 26, 2024
@RobPasMue RobPasMue changed the title fix: GetSurface not available prior to 24R2 fix: GetSurface and GetCurve not available prior to 24R2 Apr 26, 2024
Copy link
Contributor

@AlejandroFernandezLuces AlejandroFernandezLuces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just those two minor comments

@RobPasMue
Copy link
Member Author

I believe the comments don't apply @AlejandroFernandezLuces - please review my answers

b-matteo
b-matteo previously approved these changes Apr 26, 2024
Copy link
Contributor

@b-matteo b-matteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from @AlejandroFernandezLuces 's comment it looks good to me. Thanks @RobPasMue

@RobPasMue RobPasMue enabled auto-merge (squash) April 26, 2024 14:23
@RobPasMue
Copy link
Member Author

Thank you both for your reviews!

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.57%. Comparing base (4f4a656) to head (6807dfa).

Files Patch % Lines
src/ansys/geometry/core/connection/client.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1171   +/-   ##
=======================================
  Coverage   90.56%   90.57%           
=======================================
  Files          93       93           
  Lines        6987     6993    +6     
=======================================
+ Hits         6328     6334    +6     
  Misses        659      659           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AlejandroFernandezLuces AlejandroFernandezLuces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better handled with the semver package, nice addition 🙂

@RobPasMue RobPasMue disabled auto-merge April 26, 2024 17:51
@RobPasMue RobPasMue merged commit cf3d620 into main Apr 26, 2024
@RobPasMue RobPasMue deleted the fix/get-surface-24r1 branch April 26, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GetSurface is not implemented in 24R1 causing latest release of PyAnsys Geometry to fail

6 participants