Skip to content

Commit 6807dfa

Browse files
RobPasMuePipKat
andauthored
Apply suggestions from code review
Co-authored-by: Kathy Pippert <[email protected]>
1 parent e4d6a76 commit 6807dfa

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/ansys/geometry/core/designer/edge.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ def length(self) -> Quantity:
146146
try:
147147
return self.shape.length
148148
except GeometryRuntimeError: # pragma: no cover
149-
# Only for versions < 24.2.0 (i.e. before the introduction of the shape property)
149+
# Only for versions earlier than 24.2.0 (before the introduction of the shape property)
150150
self._grpc_client.log.debug("Requesting edge length from server.")
151151
length_response = self._edges_stub.GetLength(self._grpc_id)
152152
return Quantity(length_response.length, DEFAULT_UNITS.SERVER_LENGTH)

src/ansys/geometry/core/designer/face.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,7 @@ def normal(self, u: float = 0.5, v: float = 0.5) -> UnitVector3D:
313313
try:
314314
return self.shape.normal(u, v)
315315
except GeometryRuntimeError: # pragma: no cover
316-
# Only for versions < 24.2.0 (i.e. before the introduction of the shape property)
316+
# Only for versions earlier than 24.2.0 (before the introduction of the shape property)
317317
self._grpc_client.log.debug(f"Requesting face normal from server with (u,v)=({u},{v}).")
318318
response = self._faces_stub.GetNormal(GetNormalRequest(id=self.id, u=u, v=v)).direction
319319
return UnitVector3D([response.x, response.y, response.z])
@@ -347,7 +347,7 @@ def point(self, u: float = 0.5, v: float = 0.5) -> Point3D:
347347
try:
348348
return self.shape.evaluate_proportion(u, v).position
349349
except GeometryRuntimeError: # pragma: no cover
350-
# Only for versions < 24.2.0 (i.e. before the introduction of the shape property)
350+
# Only for versions earlier than 24.2.0 (before the introduction of the shape property)
351351
self._grpc_client.log.debug(f"Requesting face point from server with (u,v)=({u},{v}).")
352352
response = self._faces_stub.Evaluate(EvaluateRequest(id=self.id, u=u, v=v)).point
353353
return Point3D([response.x, response.y, response.z], DEFAULT_UNITS.SERVER_LENGTH)

0 commit comments

Comments
 (0)