-
Notifications
You must be signed in to change notification settings - Fork 401
Rename DecimalFraction units to Decimal #880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Related to #879 |
I'm not sure about this- the linked definition emphasizes the distinction between 1/2 (fraction) and 5/10 (decimal fraction). However what we're representing is the right hand side of the equation: e.g. 0.53 which is the decimal value representation of a fraction (i.e. using a decimal symbol). |
@lipchev Good point, some more googling and I believe decimal is the correct term?
|
Updated PR to use |
cfa4199
to
f752d12
Compare
f752d12
to
d2eeb3e
Compare
The problem with Ratio.Decimal is that decimal is a type in C#, so it could create confusion. |
@MarkCiliaVincenti Right, but since its type is Are we happy with Decimal? Any other suggestions? |
I personally prefer
I also think that renaming this would have quite a visible effect on client code (having obsolete warnings popping all over the place), that it simply wouldn't be worth the effort.. |
@lipchev Ok, I had not considered the "visual representation" part. I guess it makes sense when reading the wiki section. https://en.wikipedia.org/wiki/Decimal#Decimal_fractions
I guess we could call it |
Decimal fraction is not a correct term.
Changes
Ratio.Decimal
unit, markDecimalFraction
unit as obsoleteRatioChangeRate.DecimalPerSecond
, markDecimalFractionPerSecond
unit as obsoleteChanging the base unit should not be a breaking change for most users and the conversion precision is exactly the same as before for all units.