Rename Fraction units to Decimal

Author: angularsen

CodeGen/Generators/UnitsNetGen/NumberExtensionsGenerator.cs

@@ -52,9 +52,9 @@ public static class NumberTo{_quantityName}Extensions
             return Writer.ToString();
         }
 
-        private string GetObsoleteAttributeOrNull(string obsoleteText) =>
+        private static string? GetObsoleteAttributeOrNull(string obsoleteText) =>
             string.IsNullOrWhiteSpace(obsoleteText) ?
             null :
-            $"[System.Obsolete({obsoleteText})]";
+            $"[System.Obsolete(\"{obsoleteText}\")]";
     }
 }

CodeGen/Generators/UnitsNetGen/QuantityGenerator.cs

@@ -1157,6 +1157,6 @@ ulong IConvertible.ToUInt64(IFormatProvider provider)
         /// </summary>
         private static string GetObsoleteAttributeOrNull(string obsoleteText) => string.IsNullOrWhiteSpace(obsoleteText)
             ? null
-            : $"[System.Obsolete({obsoleteText})]";
+            : $"[System.Obsolete(\"{obsoleteText}\")]";
     }
 }

CodeGen/Generators/UnitsNetWrcGen/QuantityGenerator.cs

@@ -734,17 +734,17 @@ public string ToString([CanBeNull] string cultureName, [NotNull] string format,
         }
 
         /// <inheritdoc cref="GetObsoleteAttributeOrNull(string)"/>
-        internal static string GetObsoleteAttributeOrNull(Quantity quantity) => GetObsoleteAttributeOrNull(quantity.ObsoleteText);
+        internal static string? GetObsoleteAttributeOrNull(Quantity quantity) => GetObsoleteAttributeOrNull(quantity.ObsoleteText);
 
         /// <inheritdoc cref="GetObsoleteAttributeOrNull(string)"/>
-        internal static string GetObsoleteAttributeOrNull(Unit unit) => GetObsoleteAttributeOrNull(unit.ObsoleteText);
+        internal static string? GetObsoleteAttributeOrNull(Unit unit) => GetObsoleteAttributeOrNull(unit.ObsoleteText);
 
         /// <summary>
         /// Returns the Obsolete attribute if ObsoleteText has been defined on the JSON input - otherwise returns empty string
         /// It is up to the consumer to wrap any padding/new lines in order to keep to correct indentation formats
         /// </summary>
-        private static string GetObsoleteAttributeOrNull(string obsoleteText) => string.IsNullOrWhiteSpace(obsoleteText)
+        private static string? GetObsoleteAttributeOrNull(string obsoleteText) => string.IsNullOrWhiteSpace(obsoleteText)
             ? null
-            : $"[System.Obsolete({obsoleteText})]";
+            : $"[System.Obsolete(\"{obsoleteText}\")]";
     }
 }

Common/UnitDefinitions/Ratio.json

@@ -1,9 +1,22 @@
 {
   "Name": "Ratio",
-  "BaseUnit": "DecimalFraction",
+  "BaseUnit": "Decimal",
   "XmlDoc": "In mathematics, a ratio is a relationship between two numbers of the same kind (e.g., objects, persons, students, spoonfuls, units of whatever identical dimension), usually expressed as \"a to b\" or a:b, sometimes expressed arithmetically as a dimensionless quotient of the two that explicitly indicates how many times the first number contains the second (not necessarily an integer).",
   "Units": [
     {
+      "SingularName": "Decimal",
+      "PluralName": "Decimal",
+      "FromUnitToBaseFunc": "x",
+      "FromBaseToUnitFunc": "x",
+      "Localization": [
+        {
+          "Culture": "en-US",
+          "Abbreviations": [ "" ]
+        }
+      ]
+    },
+    {
+      "ObsoleteText": "Use Decimal instead. This unit will be removed.",
       "SingularName": "DecimalFraction",
       "PluralName": "DecimalFractions",
       "FromUnitToBaseFunc": "x",

Common/UnitDefinitions/RatioChangeRate.json

@@ -1,8 +1,20 @@
 {
   "Name": "RatioChangeRate",
-  "BaseUnit": "DecimalFractionPerSecond",
+  "BaseUnit": "DecimalPerSecond",
   "XmlDoc": "The change in ratio per unit of time.",
   "Units": [
+    {
+      "SingularName": "DecimalPerSecond",
+      "PluralName": "DecimalPerSecond",
+      "FromUnitToBaseFunc": "x",
+      "FromBaseToUnitFunc": "x",
+      "Localization": [
+        {
+          "Culture": "en-US",
+          "Abbreviations": [ "/s" ]
+        }
+      ]
+    },
     {
       "SingularName": "PercentPerSecond",
       "PluralName": "PercentsPerSecond",
@@ -16,6 +28,7 @@
       ]
     },
     {
+      "ObsoleteText": "Use DecimalPerSecond instead. This unit will be removed.",
       "SingularName": "DecimalFractionPerSecond",
       "PluralName": "DecimalFractionsPerSecond",
       "FromUnitToBaseFunc": "x",