Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

feat(): support multiple as a default preset method #9737

Merged
merged 1 commit into from
Oct 12, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/services/interimElement/interimElement.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ function InterimElementProvider() {
* all interim elements will come with the 'build' preset
*/
provider.addPreset('build', {
methods: ['controller', 'controllerAs', 'resolve',
methods: ['controller', 'controllerAs', 'resolve', 'multiple',
'template', 'templateUrl', 'themable', 'transformTemplate', 'parent', 'contentElement']
});

Expand Down
47 changes: 47 additions & 0 deletions src/core/services/interimElement/interimElement.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,53 @@ describe('$$interimElement service', function() {
});
});

it('should support multiple interims as a preset method', function() {

var showCount = 0;

createInterimProvider('interimTest');

inject(function(interimTest) {

showInterim(interimTest);
expect(showCount).toBe(1);

showInterim(interimTest);
expect(showCount).toBe(2);

interimTest.hide();
flush();

expect(showCount).toBe(1);

interimTest.hide();
flush();

expect(showCount).toBe(0);

});

function showInterim(service) {

var preset = service
.build()
.template('<div>Interim Element</div>')
.multiple(true);

preset._options.onShow = function() {
showCount++;
};

preset._options.onRemove = function() {
showCount--;
};

service.show(preset);
flush();
}

});

});

describe('a service', function() {
Expand Down