Skip to content
This repository was archived by the owner on Apr 4, 2025. It is now read-only.

refactor(@schematics/angular): remove rxjs blacklist import from tsli… #600

Merged
merged 1 commit into from
Apr 6, 2018

Conversation

chrste90
Copy link
Contributor

@chrste90 chrste90 commented Apr 2, 2018

…nt.json

Fixes: #585

I can also fix #570 while i am on it, but i'm not sure if these changes were made on purpose or by mistake.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@chrste90
Copy link
Contributor Author

chrste90 commented Apr 2, 2018

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Apr 2, 2018
@chrste90
Copy link
Contributor Author

chrste90 commented Apr 5, 2018

Also relates to #546

With the change in #546 tslint will throw an error when the guard is created.

@chrste90
Copy link
Contributor Author

chrste90 commented Apr 6, 2018

Friendly ping @filipesilva
Can you review please? I currently can't use rxjs on a new project without lint errors because things like Observable are now exported from rxjs directly.

@filipesilva
Copy link
Contributor

Heya @chrste90, thanks for fixing this oversight!

@filipesilva filipesilva merged commit ed109e5 into angular:master Apr 6, 2018
@filipesilva
Copy link
Contributor

I will comment on #570 directly there btw.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tslint: remove "rxjs" from import-blacklist CLI schematics regression: missing rules in tslint.json
3 participants