CLI schematics regression: missing rules in tslint.json

[cexbrayat]

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Area

- [ ] devkit
- [x] schematics

Versions

Repro steps

Just generate a project with CLI 6.0.0-beta.7.
The tslint.json file now lacks the directive-selector and component-selector rules.

Desired functionality

It should still have the rules.

Mention any other details that might be useful

See the difference between beta.6 and beta.7 cexbrayat/angular-cli-diff@6.0.0-beta.6...6.0.0-beta.7

[cexbrayat]

I just realized that the prefix option is completely ignored too when generating a new project. Is it getting removed or is it not yet implemented?

[filipesilva]

Regarding the selector rules being gone, that is a bug of sorts. I removed them because now you can generate apps and libraries, and linting would fail right after doing so.

The right behaviour is for app/lib generation to add those prefixes to tslint.

[cexbrayat]

@filipesilva I get it, but I think they should be in by default when you have just a single app. If not, beginners won't know about it. On the other hand, when you know enough to add a lib to your project, you can deal with a linting rule failing, no?

But right now the prefix is completely ignored when you generate a new app or a component, directive, which is a more important regression...

[chrste90]

I would like to look into it but have some questions first:

1. There are currently no prefixes in angular.json for apps or libs. Should these be added back as well?
2. And how should it work if there are different prefixes for each app/lib? Then the rule would be added multiple times with different values. Does this work? Or is it possible to add more than one prefix to the rules?

[clydin]

One concept is for each application/library to have its own tslint config which extends the base config. The lint command provides logic to discovery the most appropriate config. This would need to be special cased for the situation of the initial ng new.

[filipesilva]

@cexbrayat although it is true that one can just fix the linting rule manually, it's still friction. It's something we can for the user because we have all that information. The library journey doesn't need to have a note about fixing a lint rule because we (the CLI) didn't bother with it.

I think the prefix missing is just a bug really. We should save that on the prefixes for the generated app. @Brocco was there any reason it was left out, and could you give some @chrste90 some direction on how this should work?

[chrste90]

I like the idea of different tslint configs for each app/lib.

Should the ng lint command find the appropriate config at runtime or should this be added to angular.json?

[filipesilva]

The lint builder already picks the closes tslint.json file actually. So as long as there is one extending the base one, it should work.

[chrste90]

Okay. So the only thing needed is to update the schematics to create a new tslint file which extends the base tslint and adds the two missing rules? (Aside from the missing prefix in angular.json)

[filipesilva]

@chrste90 yes, for the linting issue that is all. Thanks for taking the time to look at this!

[chrste90]

No problem.

Do i need to wait for the prefix fix? Because i think the prefix should be added to the tslint config or am i wrong?