Skip to content

chore(tooltip): remove unsupported mat-tooltip selector #8786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2017
Merged

chore(tooltip): remove unsupported mat-tooltip selector #8786

merged 1 commit into from
Dec 13, 2017

Conversation

andrewseguin
Copy link
Contributor

The mat-tooltip selector was left in after the major refactorings

Technically not a breaking change since mat-tooltip doesn't work anyways (message is not populated by mat-tooltip anymore)

Fixes #8780

@andrewseguin
chore(tooltip): remove unsupported mat-tooltip selector
8107c43 
The `mat-tooltip` selector was left in after the major refactorings

Technically not a breaking change since `mat-tooltip` doesn't work anyways (message is not populated by `mat-tooltip` anymore)
@andrewseguin andrewseguin added P2 The issue is important to a large percentage of users, with a workaround pr: needs review labels Dec 3, 2017
@andrewseguin andrewseguin requested a review from jelbourn December 3, 2017 16:44
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 3, 2017
jelbourn
jelbourn approved these changes Dec 5, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 5, 2017
@mmalerba mmalerba added the target: major This PR is targeted for the next major release label Dec 6, 2017
@andrewseguin andrewseguin added target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release target: minor This PR is targeted for the next minor release labels Dec 11, 2017
@andrewseguin andrewseguin merged commit bbfec2b into master Dec 13, 2017
andrewseguin added a commit to andrewseguin/components that referenced this pull request Dec 19, 2017
@andrewseguin
chore(tooltip): remove unsupported mat-tooltip selector (angular#8786)
a53bcea 
The `mat-tooltip` selector was left in after the major refactorings

Technically not a breaking change since `mat-tooltip` doesn't work anyways (message is not populated by `mat-tooltip` anymore)
@mmalerba mmalerba deleted the andrewseguin-patch-11 branch February 20, 2018 19:30
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tooltip selector mat-tooltip not working
4 participants
@andrewseguin @jelbourn @googlebot @mmalerba