Skip to content

fix(demo-app) icon inside a button in the toolbar #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from May 13, 2016
Merged

fix(demo-app) icon inside a button in the toolbar #434

merged 2 commits into from May 13, 2016

Conversation

ghost
Copy link

@ghost ghost commented May 13, 2016

fixes #418

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label May 13, 2016
@ghost ghost changed the title fix icon inside a button in the toolbar fix(demo-app) icon inside a button in the toolbar May 13, 2016
@jelbourn
Copy link
Member

@mmgdort LGTM, we just need you to sign the CLA.

@ghost
Copy link
Author

ghost commented May 13, 2016

done!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels May 13, 2016
@jelbourn jelbourn merged commit 7323e89 into angular:master May 13, 2016
andrewseguin pushed a commit to andrewseguin/components that referenced this pull request Oct 15, 2018
alexeagle pushed a commit to alexeagle/material2 that referenced this pull request Nov 6, 2024
alexeagle pushed a commit to alexeagle/material2 that referenced this pull request Dec 12, 2024
alexeagle pushed a commit to alexeagle/material2 that referenced this pull request Dec 16, 2024
alexeagle pushed a commit to alexeagle/material2 that referenced this pull request Dec 18, 2024
josephperrott pushed a commit that referenced this pull request Dec 18, 2024
alexeagle pushed a commit to alexeagle/material2 that referenced this pull request Dec 18, 2024
kseamon pushed a commit to kseamon/material2 that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demo app: menu icon is not inside of a button
3 participants