Skip to content

Demo app: menu icon is not inside of a button #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hansl opened this issue May 10, 2016 · 2 comments · Fixed by #434
Closed

Demo app: menu icon is not inside of a button #418

hansl opened this issue May 10, 2016 · 2 comments · Fixed by #434
Labels
Accessibility This issue is related to accessibility (a11y) help wanted The team would appreciate a PR from the community to address this issue P5 The team acknowledges the request but does not plan to address it, it remains open for discussion

Comments

@hansl
Copy link
Contributor

hansl commented May 10, 2016

The md-icon in the toolbar should be focusable and clickable.
@jelbourn jelbourn changed the title Test App: mdIcon isn't focusable Demo app: menu icon is not inside of a button May 11, 2016
@jelbourn
Copy link
Member

Icons shouldn't be interactable, it should instead be the content of a button.

@jelbourn jelbourn added P5 The team acknowledges the request but does not plan to address it, it remains open for discussion Accessibility This issue is related to accessibility (a11y) help wanted The team would appreciate a PR from the community to address this issue labels May 12, 2016
@ghost ghost mentioned this issue May 13, 2016
Merged
andrewseguin pushed a commit to andrewseguin/components that referenced this issue Oct 15, 2018
@josephperrott
fix(ga): remove extra '/' (angular#418)
83fe5e9
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) help wanted The team would appreciate a PR from the community to address this issue P5 The team acknowledges the request but does not plan to address it, it remains open for discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(demo-app) icon inside a button in the toolbar
2 participants
@hansl @jelbourn