Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

feat($animator): support CSS3 transition-delay property detection #2488

Closed
wants to merge 1 commit into from

Conversation

matsko
Copy link
Contributor

@matsko matsko commented Apr 23, 2013

$animator doesn't pay attention to the CSS3 Transition Delay transition-delay property which is good for pushing an animation to start later. This fix provides that functionality.

@petebacondarwin
Copy link
Contributor

Isn't this a duplicate of #2396?

@matsko
Copy link
Contributor Author

matsko commented Apr 23, 2013

Didn't notice that one, and the code is very similar. It only took 5 min todo, so it's no big deal if it gets scrapped. Thanks for noticing the change.

@petebacondarwin
Copy link
Contributor

Check out there are a couple of other PRs related to animation that you
could take a look at.

On 23 April 2013 19:11, Matias Niemelä [email protected] wrote:

Didn't notice that one, and the code is very similar. It only took 5 min
todo, so it's no big deal if it gets scrapped.


Reply to this email directly or view it on GitHubhttps://github.com//pull/2488#issuecomment-16876045
.

@matsko
Copy link
Contributor Author

matsko commented Apr 23, 2013

I only noticed the two made by @romiem and @cburgdorf and they both relate to multiple properties and the delay values for transitions. Is there anything I missed? CSS Animations use similar properties so that's why I have this PR so that I don't have to refactor the code in twice.

@matsko matsko closed this May 7, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants