docs(tutorial): add dart version of toh tutorial #700
Conversation
| private engine: Engine; | ||
| private tires: Tires; | ||
|
|
||
| constructor() { |
|
Oh oopz @zoechi I have only converted toh-1 up to toh-4 to dart. I first just copied all the ts source files from the ts directory to the dart directory ,but I think the files about DI (dependency injection) shouldn't actually be here, so I removed them now (should probably also removed from the ts source). Also toh-5 is not converted, because the ts version is not yet finished. |
| <h2>My Heroes</h2> | ||
| <ul class="heroes"> | ||
| <li *ngFor="#hero of heroes" | ||
| [class.selected]="hero === selectedHero" |
There was a problem hiding this comment.
thanks, fixed, (will push later)
|
The |
| <h2>My Heroes</h2> | ||
| <ul class="heroes"> | ||
| <li *ngFor="#hero of heroes" | ||
| [class.selected]="hero === selectedHero" |
kasperpeulen
force-pushed
the
dart-toh
branch
from
245e733 to
ebb411d
Compare
|
@zoechi I removed that file as well now, and fixed the other comments. |
| // #docregion getHeroes | ||
| getHeroes() { | ||
| //#docregion get-heroes | ||
| heroes = _heroService.getHeroes(); |
There was a problem hiding this comment.
This is ok, it uses hero_service_1.dart where the value is returned sync.
|
I did just a shallow review but now LGTM |
|
Taking a very belated look now... |
|
@kasperpeulen could you please You can rename your .jade files to *-NEW.jade to get around some of the conflicts. And just drop the _data.json changes. |
|
Just FYI, I'm copying down the toh-1 code to submit in a separate PR. |
|
Closing, now that all changes have gotten into merged PRs. Thank you, @kasperpeulen! |
@kwalrath in this PR, I just focused on getting the Dart version up to date with the typescript version
In the other PR I ported the end result to dart, but it seems like this code was only used for plnkr, or maybe it will be used for the last part (toh-pt5), but this is not yet done for typescript it seems.