This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(dart): convert toh-5 to Dart #1426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * inject the `HeroService` in the constructor and hold it in a private `_heroService` field. | ||
| * call the service to get heroes inside the Angular `ngOnInit` lifecycle hook. | ||
|
|
||
| The noteworthy differences: we cherry-pick four heroes (2nd, 3rd, 4th, and 5th) with *slice* |
There was a problem hiding this comment.
The "with slice" suggests there is a slice operation in Dart. Maybe drop that fragment or just leave it for now and we can address it on the next round (when the doc is refactored to conform to the new design).
|
I'd say that this is good to go. We can address the other issues in the next pass. |
|
Thanks, Patrice. I'll commit this and create an issue so we don't forget to make these fixes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes based on @kasperpeulen's #700.
I also found some
"s in various toh-/.dart files, which I converted to's.@chalin could you please take a look? I seriously considered converting to your new way of including the TS file, but in the end decided to just get it out and put up what I already had.