Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

docs(dart): convert toh-5 to Dart #1426

Merged
merged 3 commits into from
May 19, 2016
Merged

docs(dart): convert toh-5 to Dart #1426

merged 3 commits into from
May 19, 2016

Conversation

kwalrath
Copy link
Contributor

Changes based on @kasperpeulen's #700.

I also found some "s in various toh-/.dart files, which I converted to 's.

@chalin could you please take a look? I seriously considered converting to your new way of including the TS file, but in the end decided to just get it out and put up what I already had.

* inject the `HeroService` in the constructor and hold it in a private `_heroService` field.
* call the service to get heroes inside the Angular `ngOnInit` lifecycle hook.

The noteworthy differences: we cherry-pick four heroes (2nd, 3rd, 4th, and 5th) with *slice*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "with slice" suggests there is a slice operation in Dart. Maybe drop that fragment or just leave it for now and we can address it on the next round (when the doc is refactored to conform to the new design).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@chalin
Copy link
Contributor

chalin commented May 19, 2016

I'd say that this is good to go. We can address the other issues in the next pass.

@kwalrath
Copy link
Contributor Author

Thanks, Patrice. I'll commit this and create an issue so we don't forget to make these fixes.

@kwalrath kwalrath merged commit 2dc6018 into angular:master May 19, 2016
@kwalrath kwalrath deleted the toh-5 branch May 19, 2016 15:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants