Skip to content

feat(SASSPlugin): Allow regexes to be passed to include/exclude certain file patterns #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2016
Merged

feat(SASSPlugin): Allow regexes to be passed to include/exclude certain file patterns #791

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/broccoli/angular-broccoli-sass.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ class SASSPlugin extends Plugin {

options = options || {};
Plugin.call(this, inputNodes, {
cacheInclude: [/\.scss$/, /\.sass$/]
cacheInclude: options.cacheInclude || [/\.scss$/, /\.sass$/],
cacheExclude: options.cacheExclude || undefined
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be [] instead of undefined?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could go either way. The broccoli-caching-writer that uses it has the line:

this._cacheExclude = options.cacheExclude || [];

I just figured undefined was "lighter" than an empty array. I'm happy to change it if you'd like.

});
this.options = options;
}
Expand Down