feat(SASSPlugin): Allow regexes to be passed to include/exclude certain file patterns #791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in file patterns Allow passing in cacheInclude and cacheExclude as options to the SASSPlugin, primarily so that filenames beginning with an underscore can be ignored during SASS/SCSS compilation, which is generally accepted to be a standard in SASS (http://sass-lang.com/guide#topic-4). These config values can be set in angular-cli-build.js thus: "sassCompiler": { "cacheExclude": [/\/_[^\/]+$/] } This arguably closes issue angular#558 (angular#558)
| @@ -18,7 +18,8 @@ class SASSPlugin extends Plugin { | |||
|
|
|||
| options = options || {}; | |||
| Plugin.call(this, inputNodes, { | |||
| cacheInclude: [/\.scss$/, /\.sass$/] | |||
| cacheInclude: options.cacheInclude || [/\.scss$/, /\.sass$/], | |||
| cacheExclude: options.cacheExclude || undefined | |||
There was a problem hiding this comment.
Shouldn't be [] instead of undefined?
There was a problem hiding this comment.
I could go either way. The broccoli-caching-writer that uses it has the line:
this._cacheExclude = options.cacheExclude || [];
I just figured undefined was "lighter" than an empty array. I'm happy to change it if you'd like.
|
LGTM |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow passing in cacheInclude and cacheExclude as options to the SASSPlugin, primarily so that filenames beginning with an underscore can be ignored during SASS/SCSS compilation, which is generally accepted to be a standard in SASS (http://sass-lang.com/guide#topic-4). These config values can be set in angular-cli-build.js thus:
This arguably closes issue #558