Skip to content

fix(@angular-devkit/build-angular): handle conditional exports in scripts and styles option #23971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2022
Merged

fix(@angular-devkit/build-angular): handle conditional exports in scripts and styles option #23971

merged 1 commit into from
Sep 30, 2022

Conversation

alan-agius4
Copy link
Collaborator

With this change scripts and styles options better support Yarn PNP resolution.

Closes #23568

@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release labels Sep 28, 2022
@alan-agius4 alan-agius4 force-pushed the script-style-yarn-pnp branch 2 times, most recently from 1d993f1 to 6f386d8 Compare September 28, 2022 12:05
@alan-agius4 alan-agius4 mentioned this pull request Sep 28, 2022
Merged
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 28, 2022
@alan-agius4 alan-agius4 removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 28, 2022
@alan-agius4 alan-agius4 force-pushed the script-style-yarn-pnp branch 2 times, most recently from f7ec116 to da4094a Compare September 29, 2022 07:24
@alan-agius4
fix(@angular-devkit/build-angular): handle conditional exports in `sc…
67cffc8 
…ripts` and `styles` option

With this change scripts and styles options better support Yarn PNP resolution.

Closes angular#23568
@alan-agius4 alan-agius4 requested a review from clydin September 29, 2022 09:46
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 29, 2022
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 30, 2022
@alan-agius4 alan-agius4 merged commit b6df9c1 into angular:main Sep 30, 2022
@alan-agius4 alan-agius4 deleted the script-style-yarn-pnp branch September 30, 2022 06:56
@michaelfaith michaelfaith mentioned this pull request Sep 30, 2022
Open
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clydin clydin clydin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Module resolution used to load styles from angular.json doesn't work with package exports
2 participants
@alan-agius4 @clydin