Skip to content

fix(material/schematics): remove node_modules prefix from prebuilt theme #25716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2022
Merged

fix(material/schematics): remove node_modules prefix from prebuilt theme #25716

merged 2 commits into from
Oct 25, 2022

Conversation

alan-agius4
Copy link
Contributor

The Angular CLI supports resolving node modules without the need of specifying node_modules directory. This also needed to add support for Yarn PNP which doesn't create a node_modules directory.

Closes #25242

@alan-agius4 alan-agius4 force-pushed the remove-pre-build-patch branch from 6da1199 to f217058 Compare September 28, 2022 11:54
@alan-agius4 alan-agius4 changed the title fix(material/schematics): remove node_modules prefix from prebuild theme fix(material/schematics): remove node_modules prefix from prebuilt theme Sep 28, 2022
@alan-agius4 alan-agius4 added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release target: major This PR is targeted for the next major release blocked This issue is blocked by some external factor, such as a prerequisite PR and removed target: patch This PR is targeted for the next patch release labels Sep 28, 2022
@alan-agius4 alan-agius4 force-pushed the remove-pre-build-patch branch 5 times, most recently from 2a304e6 to 9881038 Compare October 12, 2022 14:56
@alan-agius4 alan-agius4 removed the blocked This issue is blocked by some external factor, such as a prerequisite PR label Oct 12, 2022
@alan-agius4 alan-agius4 force-pushed the remove-pre-build-patch branch 2 times, most recently from 00a5b38 to 85b4b9c Compare October 12, 2022 15:39
@alan-agius4 alan-agius4 added target: rc This PR is targeted for the next release-candidate and removed target: major This PR is targeted for the next major release labels Oct 14, 2022
@alan-agius4 alan-agius4 force-pushed the remove-pre-build-patch branch from 7b065f3 to 0212fa6 Compare October 14, 2022 14:30
@alan-agius4 alan-agius4 marked this pull request as ready for review October 14, 2022 14:32
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer area: ng-generate Schematics that generate code in user projects and removed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Oct 14, 2022
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 14, 2022
@devversion
Copy link
Member

@alan-agius4 sorry- it looks like there is no caretaker processing. I will take care of merging if you can rebase.

@alan-agius4
fix(material/schematics): remove node_modules prefix from prebuilt …
cdb6bc2 
…theme

The Angular CLI supports resolving node modules without the need of specifying `node_modules` directory. This also needed to add support for Yarn PNP which doesn't create a `node_modules` directory.

Closes angular#25242
@alan-agius4
build: update @angular/cli packages to ^15.0.0-next.6
3c0e1a9
@alan-agius4 alan-agius4 force-pushed the remove-pre-build-patch branch from 0212fa6 to 3c0e1a9 Compare October 24, 2022 18:34
@alan-agius4
Copy link
Contributor Author

@devversion rebased.

@devversion devversion added the merge: preserve commits When the PR is merged, a rebase and merge should be performed label Oct 25, 2022
@devversion devversion merged commit 75a315e into angular:main Oct 25, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@josephperrott josephperrott Awaiting requested review from josephperrott

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: ng-generate Schematics that generate code in user projects merge: preserve commits When the PR is merged, a rebase and merge should be performed target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(schematics): ng-add prebuilt styles config isn't compatible with yarn pnp
2 participants
@alan-agius4 @devversion