Skip to content

chore(tests): Auto run tests after builds #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 63 additions & 0 deletions addon/ng2/commands/build.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
'use strict';

var path = require('path');
var Command = require('ember-cli/lib/models/command');
var win = require('ember-cli/lib/utilities/windows-admin');
var BuildCommand = require('ember-cli/lib/commands/build');
var BuildTask = require('ember-cli/lib/tasks/build');
var BuildWatchTask = require('ember-cli/lib/tasks/build-watch');
var TestTask = require('../tasks/test');

module.exports = BuildCommand.extend({
name: 'build',
description: 'Builds your app and places it into the output path (dist/ by default).',
aliases: ['b'],

availableOptions: [
{ name: 'environment', type: String, default: 'development', aliases: ['e', { 'dev': 'development' }, { 'prod': 'production' }] },
{ name: 'watch', type: Boolean, default: false, aliases: ['w'] },
{ name: 'watcher', type: String },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this watcher?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The watcher allows for specifying what mechanism will be used to watch the file system to determine if a new build needs to be run.

{ name: 'no-test', type: Boolean, default: false}
],

run: function(commandOptions){
// outputPath was removed from the avaiableOptions
// so it must be set internally
commandOptions.outputPath = 'dist/';

var BuildTask = this.tasks.Build;
var buildTask = new BuildTask({
ui: this.ui,
analytics: this.analytics,
project: this.project
});
var BuildWatchTask = this.tasks.BuildWatch;
var buildWatchTask = new BuildWatchTask({
ui: this.ui,
analytics: this.analytics,
project: this.project
});
var testTask = new TestTask({
ui: this.ui,
analytics: this.analytics,
project: this.project
});

if (!commandOptions.noTest) {
commandOptions.buildCompleted = function(){
return testTask.run({singleRun: true});
};
}

var buildTaskToRun = commandOptions.watch
? buildWatchTask
: buildTask;

return win.checkWindowsElevation(this.ui)
.then(function() {
return buildTaskToRun.run(commandOptions);
});
}
});

module.exports.overrideCore = true;
3 changes: 2 additions & 1 deletion addon/ng2/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,13 @@ module.exports = {
name: 'ng2',
includedCommands: function() {
return {
'build' : require('./commands/build'),
'new' : require('./commands/new'),
'init' : require('./commands/init'),
'install' : require('./commands/install'),
'uninstall' : require('./commands/uninstall'),
'test' : require('./commands/test'),
'e2e' : require('./commands/e2e'),
'e2e' : require('./commands/e2e'),
'lint' : require('./commands/lint'),
'format' : require('./commands/format')
};
Expand Down