Skip to content

chore(tests): Auto run tests after builds #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Brocco
Copy link
Contributor

@Brocco Brocco commented Feb 22, 2016

When running ng build or ng build --watch karma tests are run after builds
--no-test swtich to turn it off


availableOptions: [
{ name: 'environment', type: String, default: 'development', aliases: ['e', { 'dev': 'development' }, { 'prod': 'production' }] },
{ name: 'output-path', type: path, default: 'dist/', aliases: ['o'] },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a good idea to allow customizing the output path? Commands like test expect stuff to be in dist/ and will break if that changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct, this is a holdover from pulling in the ember-cli build command.

@filipesilva
Copy link
Contributor

The cli e2e test suite should also be changed I believe, otherwise tests will run twice (once on ng build, another on the subsequent ng test).

@Brocco
Copy link
Contributor Author

Brocco commented Feb 22, 2016

There will be no conflict here, nothing in the build command task chain will call the e2e command or task.

@filipesilva
Copy link
Contributor

I mean in this file, when you run tests after running build:
https://github.com/angular/angular-cli/blob/master/tests/e2e/e2e_workflow.spec.js

When running `ng build` or `ng build --watch` karma tests are run after builds
`--no-test` swtich to turn it off
@Brocco
Copy link
Contributor Author

Brocco commented Feb 24, 2016

Closing... in favor of adding watch mode to the test command

@Brocco Brocco closed this Feb 24, 2016
@Brocco Brocco deleted the test-after-build branch February 24, 2016 03:43
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants