Skip to content

Update to latest versions of redux, redux-observable, rxjs #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

jamesbs
Copy link
Member

@jamesbs jamesbs commented Jan 4, 2019

  • Fixes Latest version updates #19
  • Bump version number to 2
  • Update peer dependencies to match latest versions
  • Update webpack, karma versions to latest
  • Rework epic middleware interaction with combineDecoratedEpics to fix breaking changes resulting from move to redux-observable@1
  • Switch to typescript compiler from angular compiler
  • Rework tsconfig.json to use extends form
  • add .node-version file for nodenv

@hendrickson-tyler
Copy link

How can we implement your pull request in our project?

@jamesbs
Copy link
Member Author

jamesbs commented Jan 5, 2019

I would recommend you at least wait until the pull request gets merged into master since the PR branch may be removed, changed, etc. If you want to just play around with it right away your best bet would be to fork the repo and make sure my upgrade branch is on the fork and then use the github url syntax during npm install. ie. npm i HendricksonTyler/redux-observable-decorator#upgrade

Copy link
Member

@e-schultz e-schultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me,

Nice job with updating the readme to include breaking changes. Thanks

👍

@e-schultz e-schultz merged commit 2302dd8 into angular-redux:master Jan 8, 2019
@jamesbs jamesbs mentioned this pull request Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest version updates
3 participants