Skip to content

Angular v6 update #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alexislargaiolli
Copy link

 * Update angular modules to v6
 * Update redux to v4
 * Update redux-observable to v1
 * Update rxjs to v6
 * Update createEpics to be comptatible with rxjs 6
 * createEpics now return a rootEpic that can be used in epicMiddleware.run(rootEpic); (https://redux-observable.js.org/docs/api/createEpicMiddleware.html)
 * Remove option support in createEpics method because option can be passed to epicMiddleware.run with root epic return by createEpics
 * Update unit tests

     * Update angular modules to v6
     * Update redux to v4
     * Update redux-observable to v1
     * Update rxjs to v6
     * Update createEpics to be comptatible with rxjs 6
     * createEpics now return a rootEpic that can be used in epicMiddleware.run(rootEpic); (https://redux-observable.js.org/docs/api/createEpicMiddleware.html)
     * Remove option support in createEpics method because option can be passed to epicMiddleware.run with root epic return by createEpics
     * Update unit tests
@alexislargaiolli
Copy link
Author

Hi !

I forgot to mention that there are breaking changes. createEpics need to be use that way :

const epicMiddleware = createEpicMiddleware();
store.configureStore(
      reducers,
      {},
      [
        epicMiddleware
      ],
      devTools.isEnabled() ? [devTools.enhancer()] : []
    );
epicMiddleware.run(createEpics(...));

And epicMiddleware.run can take options directly.

I tried this update in an angular 6 project and it work like a charm.

@e-schultz
Copy link
Member

Hi @alexislargaiolli - thanks for taking a look at this. I've been away from Angular projects for a few months, I'll try and take a look at this soon and see if I can get it merged in / published.

@alexislargaiolli
Copy link
Author

Hi @e-schultz ! You welcome ! Thank you for this useful tiny lib.

The tests pass but the CI fails for another reason.

@jamesbs
Copy link
Member

jamesbs commented Jan 8, 2019

Thank you for the effort but closing this in favour of #21

@jamesbs jamesbs closed this Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants