Fix docs #293
Merged
Fix docs #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jooohhn
commented
Sep 10, 2020
jooohhn
commented
- Fix deadlinks (Docs: Configuration Options link is broken. #291)
- Add new line spacing to long content
- Add deprecation notes and styling
kelvin-lu
reviewed
Sep 10, 2020
website/generate-jsdoc.js
Outdated
| } | ||
|
|
||
| function documentDeprecated(data) { | ||
| return `<div style={{ padding: '10px', backgroundColor: '#ff4c59' }}> |
Contributor
There was a problem hiding this comment.
how is this affected by the dark/light modes ( i.e. will the dark mode cause text here to appear white)? It looks like this background flags a small warning on wcag color difference with black text and fails AA criteria with white text.
Contributor
Author
There was a problem hiding this comment.
Updated it, I think it should be good for AA standards now
haoliu-amp
approved these changes
Sep 10, 2020
jooohhn
added a commit
to jooohhn/Amplitude-JavaScript
that referenced
this pull request
Sep 21, 2020
* fix multiple param/return types generation * fix dead links * clean up docs spacing and content * fix deprecated notes in amplitude.js * Add style support for deprecated docs * Add admonitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.