Skip to content

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented Aug 7, 2024

Co-authored-by: Sam Bull [email protected]
(cherry picked from commit c4acabc)

Co-authored-by: Sam Bull <[email protected]>
(cherry picked from commit c4acabc)
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Aug 7, 2024
@bdraco bdraco changed the title Fix timer handle churn in websocket heartbeat (#8608) [PR #8608/c4acabc backport][3.10] Fix timer handle churn in websocket heartbeat Aug 7, 2024
@codecov
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.66%. Comparing base (72f41aa) to head (b92861f).
Report is 205 commits behind head on 3.10.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.10    #8639      +/-   ##
==========================================
+ Coverage   97.63%   97.66%   +0.03%     
==========================================
  Files         108      108              
  Lines       33698    33852     +154     
  Branches     4016     4027      +11     
==========================================
+ Hits        32902    33063     +161     
+ Misses        591      588       -3     
+ Partials      205      201       -4     
Flag Coverage Δ
CI-GHA 97.58% <100.00%> (+0.03%) ⬆️
OS-Linux 97.25% <100.00%> (+0.03%) ⬆️
OS-Windows 94.76% <100.00%> (+0.01%) ⬆️
OS-macOS 96.92% <98.55%> (+0.02%) ⬆️
Py-3.10.11 97.03% <98.55%> (+0.02%) ⬆️
Py-3.10.14 96.98% <100.00%> (+0.03%) ⬆️
Py-3.11.9 97.21% <100.00%> (+0.03%) ⬆️
Py-3.12.4 97.33% <100.00%> (+0.03%) ⬆️
Py-3.8.10 94.50% <100.00%> (+0.01%) ⬆️
Py-3.8.18 96.88% <100.00%> (+0.03%) ⬆️
Py-3.9.13 97.03% <98.55%> (+0.02%) ⬆️
Py-3.9.19 96.99% <100.00%> (+0.03%) ⬆️
Py-pypy7.3.16 96.57% <100.00%> (+0.03%) ⬆️
VM-macos 96.92% <98.55%> (+0.02%) ⬆️
VM-ubuntu 97.25% <100.00%> (+0.03%) ⬆️
VM-windows 94.76% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review August 7, 2024 22:33
@bdraco bdraco merged commit 68e8496 into 3.10 Aug 7, 2024
@bdraco bdraco deleted the patchback/backports/3.10/c4acabc836ab969e95199aa976e85c01df720a27/pr-8608 branch August 7, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant