Skip to content

Conversation

@Olegt0rr
Copy link
Contributor

What do these changes do?

Backport #8338

Are there changes in behavior for the user?

Is it a substantial burden for the maintainers to support this?

Related issue number

Relates #8338

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

@Olegt0rr Olegt0rr requested a review from asvetlov as a code owner April 16, 2024 18:27
@Olegt0rr Olegt0rr marked this pull request as draft April 16, 2024 18:45
@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Jul 17, 2024
@bdraco bdraco changed the title Backport tests 3.10 [PR #8338 backport][3.10] Backport tests 3.10 Jul 17, 2024
@bdraco bdraco changed the title [PR #8338 backport][3.10] Backport tests 3.10 [PR #8338/dc457842 backport][3.10] Add some coverage Jul 17, 2024
@bdraco bdraco marked this pull request as ready for review July 17, 2024 16:25
@codecov
Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.53%. Comparing base (776ebc6) to head (8efc27c).
Report is 213 commits behind head on 3.10.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.10    #8341      +/-   ##
==========================================
+ Coverage   96.78%   97.53%   +0.74%     
==========================================
  Files         106      108       +2     
  Lines       33411    33516     +105     
  Branches     3997     4019      +22     
==========================================
+ Hits        32337    32689     +352     
+ Misses        830      602     -228     
+ Partials      244      225      -19     
Flag Coverage Δ
CI-GHA 97.44% <100.00%> (+0.71%) ⬆️
OS-Linux 97.11% <100.00%> (?)
OS-Windows 94.71% <100.00%> (?)
OS-macOS 96.78% <100.00%> (+0.05%) ⬆️
Py-3.10.11 96.89% <100.00%> (?)
Py-3.10.14 96.85% <100.00%> (?)
Py-3.11.9 97.08% <100.00%> (?)
Py-3.12.4 97.19% <100.00%> (+0.64%) ⬆️
Py-3.8.10 94.45% <100.00%> (?)
Py-3.8.18 96.75% <100.00%> (?)
Py-3.9.13 96.89% <100.00%> (+0.35%) ⬆️
Py-3.9.19 96.86% <100.00%> (?)
Py-pypy7.3.16 96.42% <100.00%> (?)
VM-macos 96.78% <100.00%> (+0.05%) ⬆️
VM-ubuntu 97.11% <100.00%> (?)
VM-windows 94.71% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco enabled auto-merge (squash) July 21, 2024 15:22
@bdraco bdraco merged commit 35b5508 into aio-libs:3.10 Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:skip This PR does not need to include a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants