fix: allow detached elements to be used as content for an overlay #1588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Westbrook
force-pushed
the
westbrook/overlay-content
branch
from
823dad4 to
b1e4f25
Compare
Westbrook
force-pushed
the
westbrook/overlay-content
branch
from
6a8b007 to
cee02c5
Compare
najikahalsema
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
document.createElement('div')) to be used as "content" in an overlayRelated Issue
fixes #1540
Motivation and Context
Alternatives to rendering into a document fragment when you don't want the overlay content to exist in the DOM when closed should be available.
How Has This Been Tested?
Types of changes
Checklist: