Select on initial focus #2026
Merged
Select on initial focus #2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
LFDanLu
requested changes
Jun 15, 2021
LFDanLu
reviewed
Jun 16, 2021
| manager.setFocused(true); | ||
|
|
||
| if (manager.focusedKey == null) { | ||
| let navigateToFirstKey = (key: Key | undefined, childFocus?: FocusStrategy) => { |
Member
There was a problem hiding this comment.
Is the childFocus bit prep for grid cases w/ focusable children? Just trying to figure out if useSelectableCollection will have access to childFocus information in onFocus
Member
Author
There was a problem hiding this comment.
so this function is actually stolen from above https://github.com/adobe/react-spectrum/blob/main/packages/@react-aria/selection/src/useSelectableCollection.ts#L114
it's a bit of copy pasta that i forgot about because lint didn't yell at me, it seems as though childFocus is only for arrow keys, so I'm thinking we don't need to worry about it at all
# Conflicts: # packages/@react-aria/selection/test/useSelectableCollection.test.js
|
Build successful! 🎉 |
LFDanLu
approved these changes
Jun 30, 2021
Member
|
Would be nice to have a better PR title and maybe a description for this so I don't need to go to the original bug to find out what this is. 😉 |
snowystinger
changed the title
# Conflicts: # packages/@react-aria/selection/test/useSelectableCollection.test.js
dannify
pushed a commit
that referenced
this pull request
Oct 15, 2021
…tView (#2363) * Followup to selectOnFocus add demo stories fix clicking without shift * add selectionBehavior * Add story for useSelectableList * update default * cleanup stories * remove extraneous dependency * support keyboard navigation without replacing the selection in select on focus mode * fix lint * Touch multiselect always use toggle (#2046) * Mobile updates for selection * Move mobile awareness to the component * fix lint * move to touch/vo detection * Select on initial focus (#2026) * Select on focus first time in collection * fix lint * Only start selecting on first focus if selectOnFocus is on * add a test * fix aria * fix lint * remove dead code * fix lint * fix lint * Fix ctrl + alt + space * Hide checkboxes and add border for highlight selection mode * Expose selectionBehavior option on SelectionManager * Don't show focus ring when pressing modifier keys * Fix test * Fix table tests * Add useLongPress to @react-aria/interactions * Implement onAction support in TableView * Add highlight selection and onAction support to ListView * Fix tests * Fix ListView onAction with no selection * Only require alt key not ctrl + alt * Fix CardView tests * Prevent context menu on touch * Improve event cleanup * Change non-contiguous selection modifier depending on platform * Rename to selectionStyle in Spectrum and fix some bugs * Enforce selection mode better * code review * Remove global styles from story * Add stopPropagation back when continuePropagation is not available Co-authored-by: Rob Snow <[email protected]> Co-authored-by: Rob Snow <[email protected]> Co-authored-by: Daniel Lu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1905
Fixes a bug where tabbing into a collection with selectOnFocus wouldn't select anything until the arrow key was used. Now this will select the item that first gains focus.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: