raise default volume #13
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some further testing with different speakers and headphones with the boot animation and audio examples from https://github.com/adafruit/Adafruit_CircuitPython_FruitJam/tree/main/examples I'm thinking that the default volume is still a little low for most wav files.
This bumps the default volume levels a little bit for both speaker and headphone.
I tested the new values with boot animation and those audio examples on speakers, earbuds, and 3.5mm speakers. The JST Speaker is still a little quiet, but I'm hesitant to push it much further since it's such a tiny speaker. With the changes from this PR, and this one from the fruit jam repo: adafruit/Adafruit_CircuitPython_FruitJam#22 the JST speaker starts to become audible to my ear at around
0.5
volume using the 0.0 - 1.0 scale introduced by that fruit jam PR, below that I can either not hear anything, or can hear it very faintly if I put the fruit jam up to my ear.