change volume api to 0.0-1.0 #22
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
requested changes
Sep 16, 2025
adafruit_fruitjam/peripherals.py
Outdated
| def volume(self) -> int: | ||
| def volume(self) -> float: | ||
| """ | ||
| The volume level of the Fruit Jam audio output. Valid values are 1-20. |
There was a problem hiding this comment.
This comment needs updating to use 0.0 - 1.0.
There was a problem hiding this comment.
Thank you. This is fixed in the latest commit.
This was referenced Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
peripherals.volumeis updated to use a float value 0.0 to 1.0 instead of int value 1-20.The 3 examples in this repo that make use of
volumeare updated to use new values.The new safe volume limit is a little bit higher relative to the old one, was
12/20is now0.75.I'm opening this PR as a draft to start because there are updates needed in Fruit Jam OS and a few of the apps / games that are included from the Learn repo. I'll submit PRs for those changes as well, and convert all of them out of draft once ready. I also have some tweaks to the default volume level that is set by TLV320 library that I will submit with these PRs.