Add, test support for chunk extensions #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The chunk line is read up to the terminating "\r\n", then any extensions are ignored by only using the string up to the first ";" (if any) when determining the length of the chunk. Resources: https://tools.ietf.org/html/rfc7230#section-4.1.1 https://www.boost.org/doc/libs/1_74_0/libs/beast/doc/html/beast/using_http/chunked_encoding.html
jepler
force-pushed
the
jepler-patch-1
branch
from
26a0445 to
717e57f
Compare
tannewt
requested changes
Nov 2, 2020
tests/chunk_test.py
Outdated
| print(c) | ||
| sock = mocket.Mocket(headers + c) | ||
| pool.socket.return_value = sock | ||
| for extra in (b"", b";blahblah; blah"): |
There was a problem hiding this comment.
Mind copying and pasting this into a new test function? That will lead to a clearer failure if/when it fails. Right now it's lumped into the basic case.
There was a problem hiding this comment.
I've updated the test, let me know if it's still not what you're looking for.
|
@jepler Are you going to follow up on this? |
tannewt
approved these changes
Nov 10, 2020
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 14, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_IL0373 to 1.3.2 from 1.3.1: > Merge pull request adafruit/Adafruit_CircuitPython_IL0373#14 from tannewt/tune_grayscale Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3MDL to 1.1.6 from 1.1.5: > Merge pull request adafruit/Adafruit_CircuitPython_LIS3MDL#14 from Breefield/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_MONSTERM4SK to 0.1.1 from 0.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_MONSTERM4SK#5 from FoamyGuy/fix_refrences_to_old_repo_name Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 4.3.0 from 4.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#50 from brentru/fix-throttling-message-parsing Updating https://github.com/adafruit/Adafruit_CircuitPython_MagTag to 1.0.1 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#2 from ladyada/main Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 1.9.4 from 1.9.3: > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#50 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.8.0 from 1.7.5: > Merge pull request adafruit/Adafruit_CircuitPython_Requests#46 from adafruit/jepler-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_Slideshow to 1.3.1 from 1.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_Slideshow#24 from FoamyGuy/alignment_example Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_MagTag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chunk line is read up to the terminating "\r\n", then any extensions are ignored by only using the string up to the first ";" (if any) when determining the length of the chunk.
Resources:
https://tools.ietf.org/html/rfc7230#section-4.1.1
https://www.boost.org/doc/libs/1_74_0/libs/beast/doc/html/beast/using_http/chunked_encoding.html
Thanks to @anecdata for asking on Discord why ";" was getting special treatment, leading to this investigation. We don't know of a specific URL or service that is affected by this bug.