Skip to content

Update examples to reflect changes to adafruit_lsm6ds #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 9, 2020

Conversation

Breefield
Copy link
Contributor

@Breefield Breefield commented Nov 5, 2020

adafruit_lsm6ds is a module now, these imports must change to reflect that

adafruit_lsm6ds is a module now, these imports change
@Breefield Breefield changed the title Update lis3mdl_lsm6ds_test.py Update examples to reflect changes to adafruit_lsm6ds Nov 5, 2020
@tannewt tannewt requested a review from siddacious November 5, 2020 18:55
@Breefield Breefield marked this pull request as ready for review November 5, 2020 18:56
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Breefield thanks for fixing these! Can you make the sub-module names lowercase so that they'll match the name of the file that that they're inside of.
like:

from adafruit_lsm6ds.lsm6dox import LSM6DSOX as LSM6DS

Other than that these changes look good to me. Tested successfully on Feather nrf52840.

@Breefield
Copy link
Contributor Author

👍

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks again @Breefield

@siddacious siddacious merged commit aa720bc into adafruit:master Nov 9, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Nov 14, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_IL0373 to 1.3.2 from 1.3.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_IL0373#14 from tannewt/tune_grayscale

Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3MDL to 1.1.6 from 1.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_LIS3MDL#14 from Breefield/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_MONSTERM4SK to 0.1.1 from 0.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MONSTERM4SK#5 from FoamyGuy/fix_refrences_to_old_repo_name

Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 4.3.0 from 4.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#50 from brentru/fix-throttling-message-parsing

Updating https://github.com/adafruit/Adafruit_CircuitPython_MagTag to 1.0.1 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#2 from ladyada/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 1.9.4 from 1.9.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#50 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.8.0 from 1.7.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#46 from adafruit/jepler-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_Slideshow to 1.3.1 from 1.3.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Slideshow#24 from FoamyGuy/alignment_example

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_MagTag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants