Apply rotation to display touch #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheKitty
approved these changes
Dec 10, 2025
Collaborator
Author
|
It appears to be failing because the latest version of Display Text broke PortalBase. |
Collaborator
Author
|
Once adafruit/Adafruit_CircuitPython_PortalBase#119 gets merged, the checks should pass and I'll re-run them. |
adafruit-adabot
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 11, 2025
Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.11.6 from 3.11.5: > Merge pull request adafruit/Adafruit_CircuitPython_GPS#121 from adafruit/dhalbert-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM6DS to 4.6 from 4.5.18: > Merge pull request adafruit/Adafruit_CircuitPython_LSM6DS#68 from mikeysklar/low-power Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 3.4.2 from 3.4.1: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#231 from adafruit/Neradoc-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 3.4.3 from 3.4.2: > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#119 from makermelissa/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Qualia to 2.2.0 from 2.1.3: > Merge pull request adafruit/Adafruit_CircuitPython_Qualia#15 from makermelissa/main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14. This is apparently something I had overlooked. Since the touch drivers don't have a rotation property, I am transforming the values returned by the driver depending on the rotation. I created a wrapper class so that no user code needs to be updated.