Skip to content

Conversation

@makermelissa
Copy link
Collaborator

My PR for a separate library that depends on PortalBase is failing checks. This simple change should fix the issue, but still remain backwards compatible.

@Neradoc
Copy link
Contributor

Neradoc commented Dec 10, 2025

Note adafruit/Adafruit_CircuitPython_Display_Text#231
OutlinedLabel was misspelled as OutlineLabel. That PR should fix it making this one unnecessary.

@FoamyGuy
Copy link
Contributor

FoamyGuy commented Dec 10, 2025

I think this is addressing something different from the misspelled name.

This adds compatibility with both the brand new release where BitmapLabel supports outlines, and the older release where OutlinedLabel was only a separate class.

This is good especially for PortalBase because PyPortals, MagTags and perhaps some others of the devices that use PortalBase have display text frozen in, so they'll be on a longer timeline for folks to get the latest version available without resorting to using root folder libs. While FruitJam and maybe some others do not have frozen display text. This change allows all of them to work as expected both before and after they get updated to the latest version.

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@makermelissa makermelissa merged commit 059c805 into adafruit:main Dec 10, 2025
1 check passed
adafruit-adabot pushed a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 11, 2025
Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.11.6 from 3.11.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_GPS#121 from adafruit/dhalbert-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM6DS to 4.6 from 4.5.18:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM6DS#68 from mikeysklar/low-power

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 3.4.2 from 3.4.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#231 from adafruit/Neradoc-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 3.4.3 from 3.4.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#119 from makermelissa/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_Qualia to 2.2.0 from 2.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_Qualia#15 from makermelissa/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants