RangeError: Maximum call stack size exceeded at recursiveTypeRelatedTo after upgrading to 3.0

[hkjeffchan]

import { Model, RelationMappings, RelationMappingsThunk } from 'objection';

export class BaseModel extends Model {
  id: number;

  static get modelPaths() {
    return [__dirname];
  }
}

export class Product extends BaseModel {
  static tableName = 'product';
  price: number;
  user?: User;

  static relationMappings: RelationMappings | RelationMappingsThunk = {
    productList: {
      relation: Model.BelongsToOneRelation,
      modelClass: 'User',
      join: {
        from: 'product.userId',
        to: 'user.id',
      },
    },
  };
}

export class User extends BaseModel {
  static tableName = 'user';
  name: string;
  // productList?: Product;

  static relationMappings: RelationMappings | RelationMappingsThunk = {
    productList: {
      relation: Model.HasManyRelation,
      modelClass: 'Product',
      join: {
        from: 'user.id',
        to: 'product.userId',
      },
    },
  };
}

If I uncomment the line "productList?: Product", I got the following error:
RangeError: Maximum call stack size exceeded
at recursiveTypeRelatedTo (/Applications/MAMP/htdocs/test-obj3/node_modules/typescript/lib/typescript.js:63793:44)
at isRelatedTo (/Applications/MAMP/htdocs/test-obj3/node_modules/typescript/lib/typescript.js:63388:30)
at typeRelatedToSomeType (/Applications/MAMP/htdocs/test-obj3/node_modules/typescript/lib/typescript.js:63654:35)
at structuredTypeRelatedToWorker (/Applications/MAMP/htdocs/test-obj3/node_modules/typescript/lib/typescript.js:63926:32)
at structuredTypeRelatedTo (/Applications/MAMP/htdocs/test-obj3/node_modules/typescript/lib/typescript.js:63908:30)
at isRelatedTo (/Applications/MAMP/htdocs/test-obj3/node_modules/typescript/lib/typescript.js:63385:30)
at checkTypeRelatedTo (/Applications/MAMP/htdocs/test-obj3/node_modules/typescript/lib/typescript.js:63003:26)
at isTypeRelatedTo (/Applications/MAMP/htdocs/test-obj3/node_modules/typescript/lib/typescript.js:62954:24)
at isTypeAssignableTo (/Applications/MAMP/htdocs/test-obj3/node_modules/typescript/lib/typescript.js:62160:20)
at getConditionalType (/Applications/MAMP/htdocs/test-obj3/node_modules/typescript/lib/typescript.js:60943:133)

This only happens after upgrading to objection@3.0.0. This is fine in 2.x.

Already set tsconfig to
"strict": true,

Seems related to
microsoft/TypeScript#33460

[hkjeffchan]

setting "strictNullChecks": false can fix temporarily

[koskimas]

Already set tsconfig to
"strict": true,

Are you sure? Your example won't compile in strict mode. id: number; and name: string; won't work in strict mode.

[sjinks]

Here is a test project to reproduce the issue.

test.zip

npm test fails with "RangeError: Maximum call stack size exceeded"

Adding "strictNullChecks": true to tsconfig.json fixes the issue for me (the test still fails but that's because I removed the non-relevant code).

[sjinks]

Running npm i objection@2 knex@"<0.95.0" and updating the imports fixes the issue.

[sjinks]

Replacing QueryBuilder<ImageModel> with QueryBuilder<Model> also fixes the issue :-)

[koskimas]

Unfortunately I don't have time to debug or fix this for you. You'll have to do it yourself. I'll merge the PR.

[JeongJuhyeon]

I find the "strict: true" thing almost to be the opposite.
I've copied the example and at Typescript@4.5.2. "strict: true": No error, inference works but performance is very slow; it takes ~5 seconds for any kind of inference to pop up. "strict: false": No error, inference works and everything is very fast.

[hkjeffchan]

Already set tsconfig to
"strict": true,

Are you sure? Your example won't compile in strict mode. id: number; and name: string; won't work in strict mode.

sorry, forgot to mention. The following is set:

"strictPropertyInitialization": false

[hkjeffchan]

Another found:

Downgraded typescript to 4.3 works like a charm even with "strictNullChecks": true

[sjinks]

"typescript": "<4.5.3" works.

[Linksku]

Linking my fix without downgrading TS: #2132 (comment)

[koskimas]

Thank you @Linksku! Awesome work!