[tsc] Regression causing 'Maximum call stack size exceeded'

[lookfirst]

Hopefully this one can get fixed quickly since it is a pretty major regression. I spent a lot of time figuring out exactly which version range is causing the failure as well as trying to figure out a minimal test case.

TypeScript Version:

Failure at version: 3.6.0-dev.20190807 and above.
Everything works: 3.6.0-dev.20190806 and lower.

Code

tsc-fail.zip

To run:

yarn
./node_modules/.bin/tsc

Expected behavior:

No error.

Actual behavior:

tsc-fail/node_modules/typescript/lib/tsc.js:75299
                throw e;
                ^

RangeError: Maximum call stack size exceeded
    at Object.getObjectFlags (tsc-fail/node_modules/typescript/lib/tsc.js:10227:28)
    at isExcessPropertyCheckTarget (tsc-fail/node_modules/typescript/lib/tsc.js:42328:51)
    at Object.every (tsc-fail/node_modules/typescript/lib/tsc.js:295:22)
    at isExcessPropertyCheckTarget (tsc-fail/node_modules/typescript/lib/tsc.js:42331:44)
    at isKnownProperty (tsc-fail/node_modules/typescript/lib/tsc.js:42317:52)
    at hasCommonProperties (tsc-fail/node_modules/typescript/lib/tsc.js:37523:21)
    at isRelatedTo (tsc-fail/node_modules/typescript/lib/tsc.js:36276:58)
    at typeRelatedToSomeType (tsc-fail/node_modules/typescript/lib/tsc.js:36458:35)
    at isRelatedTo (tsc-fail/node_modules/typescript/lib/tsc.js:36300:34)
    at isPropertySymbolTypeRelated (tsc-fail/node_modules/typescript/lib/tsc.js:37137:28)

[lookfirst]

Maybe related: #32582

[lookfirst]

Running with 3.6.3 the error has changed a bit...

RangeError: Maximum call stack size exceeded
    at recursiveTypeRelatedTo (/node_modules/typescript/lib/tsc.js:36800:44)
    at isRelatedTo (/node_modules/typescript/lib/tsc.js:36477:38)
    at typeRelatedToSomeType (/node_modules/typescript/lib/tsc.js:36614:35)
    at isRelatedTo (/node_modules/typescript/lib/tsc.js:36456:34)
    at eachTypeRelatedToType (/node_modules/typescript/lib/tsc.js:36736:35)
    at isRelatedTo (/node_modules/typescript/lib/tsc.js:36452:25)
    at isPropertySymbolTypeRelated (/node_modules/typescript/lib/tsc.js:37293:28)
    at propertyRelatedTo (/node_modules/typescript/lib/tsc.js:37333:31)
    at propertiesRelatedTo (/node_modules/typescript/lib/tsc.js:37434:43)
    at isRelatedTo (/node_modules/typescript/lib/tsc.js:36468:34)

[lookfirst]

Version 3.7.0-dev.20190917

/node_modules/typescript/lib/tsc.js:75802
                throw e;
                ^

RangeError: Maximum call stack size exceeded
    at isUnconstrainedTypeParameter (/node_modules/typescript/lib/tsc.js:37850:46)
    at /node_modules/typescript/lib/tsc.js:37854:105
    at Object.some (/node_modules/typescript/lib/tsc.js:673:25)
    at isTypeReferenceWithGenericArguments (/node_modules/typescript/lib/tsc.js:37854:58)
    at getRelationKey (/node_modules/typescript/lib/tsc.js:37884:17)
    at recursiveTypeRelatedTo (/node_modules/typescript/lib/tsc.js:36895:26)
    at isRelatedTo (/node_modules/typescript/lib/tsc.js:36568:38)
    at eachTypeRelatedToType (/node_modules/typescript/lib/tsc.js:36827:35)
    at isRelatedTo (/node_modules/typescript/lib/tsc.js:36543:25)
    at isPropertySymbolTypeRelated (/node_modules/typescript/lib/tsc.js:37393:28)    

[koskimas]

This also happens with objection.js typings. I don't know if this helps, but you can reproduce it like this:

git clone git@github.com:Vincit/objection.js.git
git checkout typescript-issue-33460
npm install
npm install typescript@3.6.3
npm run test-typings

Using the package.json version 3.5.3 works

npm install typescript@3.5.3
npm run test-typings

I was able to find out that this monstrosity of a type is the culprit:

[koskimas]

Oh, the original reproduction was also done using objection typings 😄

[lookfirst]

@koskimas I'm also sorry to say that I've now moved on from Objection to MikroORM. =(

[koskimas]

I just found out that changing this

  type GraphParameters = {
    '#dbRef'?: MaybeCompositeId;
    '#ref'?: string;
    '#id'?: string;
  };

  type PartialModelGraph<T> = {
    [K in NonFunctionPropertyNames<T>]?: Exclude<T[K], undefined> extends Model
      ? PartialModelGraph<Exclude<T[K], undefined>>
      : Exclude<T[K], undefined> extends Array<infer I>
      ? (I extends Model ? PartialModelGraph<I>[] : (T[K] | NonPrimitiveValue))
      : (T[K] | NonPrimitiveValue);
  } &
    GraphParameters;

into this

  type GraphParameters = {
    '#dbRef'?: MaybeCompositeId;
    '#ref'?: string;
    '#id'?: string;
  };

  type PartialModelGraph<M, T = M & GraphParameters> = {
    [K in NonFunctionPropertyNames<T>]?: Exclude<T[K], undefined> extends Model
      ? PartialModelGraph<Exclude<T[K], undefined>>
      : Exclude<T[K], undefined> extends Array<infer I>
      ? (I extends Model ? PartialModelGraph<I>[] : (T[K] | NonPrimitiveValue))
      : (T[K] | NonPrimitiveValue);
  }

fixes the problem.

Also note that @lookfirst's reproduction uses objection 1.6.9 while the above types and my repro is with objection 2.0 typings which have been completely rewritten from scratch. So this fix only applies to my repro.