05-descendant-combinator: Remove child combinator from solution.css #561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Child combinator is not considered as a descendant combinator, therefore it should not be listed as a possible combinator.
mao-sz
approved these changes
Jun 15, 2024
jitu660
pushed a commit
to jitu660/css-exercises
that referenced
this pull request
Aug 2, 2024
Child combinator is not considered as a descendant combinator, therefore it should not be listed as a possible combinator.
TeamPlatinum1
pushed a commit
to TeamPlatinum1/css-exercises
that referenced
this pull request
Sep 3, 2024
Child combinator is not considered as a descendant combinator, therefore it should not be listed as a possible combinator.
nanafox
pushed a commit
to nanafox/css-exercises
that referenced
this pull request
Nov 8, 2024
Child combinator is not considered as a descendant combinator, therefore it should not be listed as a possible combinator.
Oussama5379
added a commit
to Oussama5379/css-exercises
that referenced
this pull request
Feb 1, 2025
Child combinator is not considered as a descendant combinator, therefore it should not be listed as a possible combinator.
CourtzDee
pushed a commit
to CourtzDee/css-exercises
that referenced
this pull request
Apr 2, 2025
Child combinator is not considered as a descendant combinator, therefore it should not be listed as a possible combinator.
repo-jr
added a commit
to repo-jr/css-exercises
that referenced
this pull request
Aug 29, 2025
Child combinator is not considered as a descendant combinator, therefore it should not be listed as a possible combinator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
The div > p option in
solution.cssfile is listed as a possible descendant combinator. According to MDN, it is not a descendant combinator, and it actually enforces stricter inheritance between parent and child element relationships, therefore it should not be listed as a possible combinator.This PR
Issue
Closes #558
Additional Information
None.
Pull Request Requirements
location of change: brief description of changeformat, e.g.01-flex-center: Update self checkBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection