Skip to content

Bug - Foundations exercise 5: Child combinator wrongly labeled as descendant combinator in solution #558

@dybucc

Description

@dybucc

Complete the following REQUIRED checkboxes:

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this issue follows the Bug - location of bug: brief description of bug format, e.g. Bug - Grid exercises: CSS not properly linked to HTML files

The following checkbox is OPTIONAL:

  • I would like to be assigned this issue to work on it

1. Description of the Bug:

In the solution for the exercise, there's a few options listed as alternatives to the descendant combinator. It's' basically a mix-and-match of classes and type selectors. But there's an option that isn't actually a descendant combinator, but a child combinator. This is the div > p option. According to MDN, it is not a descendant combinator, and it actually enforces stricter inheritance between parent and child element relationships.

2. How To Reproduce:

Look through the foundations/05-descendant-combinator/solution/solution.css, and compare with https://developer.mozilla.org/en-US/docs/Web/CSS/Child_combinator and https://developer.mozilla.org/en-US/docs/Web/CSS/Descendant_combinator.

3. Expected Behavior:

For either the solution not to include the child combinator itself as an alternative descendant combinator, or to possibly include another link in the corresponding TOP page, this being Intro to CSS, as an Additional Resource to know more about other combinators, considering the lesson itself does mention their existence but doesn't go into any further details.

4. Desktop/Device:

  • Device: No specific device.
  • OS: No specific device.
  • Browser: No specific device.
  • Version: No specific device.

5. Additional Information:

None.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Status: Help WantedThis issue can be assigned to other contributorsType: Easy FixInvolves a minor fix such as grammar, syntax, etc.Type: Good First IssueGood for beginner contributors

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions