Skip to content

Wave #6061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 38 commits into from
Jun 23, 2022
Merged

Wave #6061

merged 38 commits into from
Jun 23, 2022

Conversation

meg-1
Copy link
Contributor

@meg-1 meg-1 commented Mar 23, 2022 •
edited
Loading

Describe your change:

this algorithm returns a so called 'wave' of a given string [ a list of each of it's capitalized charachters one by one. ]

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

meg-1 and others added 27 commits May 16, 2021 13:18
@meg-1
Added censor function
00c22a3
@meg-1
Added censor code
4194344
@meg-1
Added comments to the code
e7d4102
@meg-1
modified censor function
93bd4ac
@meg-1
added decrypt function
b714278
@meg-1
added cypher and decypher functions, deleted censor and decrypt funct…
c879c7f 
…ions
@meg-1
Deleted decrypt.py
e60dd6f
@meg-1
Deleted censor.py
b3e0cb8
@meg-1
Merge branch 'TheAlgorithms:master' into master
e14b9ef
@meg-1
edited the crypt and decrypt files
947f7d8
@meg-1
Update cypher_txt.py
daf21ad
@meg-1
Remove the endline in cypher.py
d3d8b29
@meg-1
Removed the print at the end of decypher.py
752c197
@meg-1
comitting changes
9f44028
@meg-1
added 4 new algorithms
f72431b
@meg-1
added tests to the four files
4c891f4
@meg-1
added type hints for the function variables
c600b10
@meg-1
Merge branch 'TheAlgorithms:master' into master
4286e40
@meg-1
Deleted decode message
7a909e2
@meg-1
Deleted code message
f5b5411
@meg-1
Welford average algorithm
bc8388c
@meg-1
added average welford algorithm
9be479e
@meg-1
is_narcissistic added
f3fb7e6
@meg-1
added a descriptive name
d00d135
@meg-1
added max_sectors algorithm
b3b3cfa
@meg-1
added find_unique
6a39087
@meg-1
added wave algorithm
dead6eb
@meg-1 meg-1 requested a review from Kush1101 as a code owner March 23, 2022 15:54
This was referenced Mar 23, 2022
Closed
Closed
@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Mar 23, 2022
@poyea
Copy link
Member

poyea commented Mar 24, 2022 •
edited
Loading

Looks like this is a combination of #5883, and #6052.
I suggest you split them into individual PRs. That would be easier to review

@meg-1
Copy link
Contributor Author

meg-1 commented Mar 30, 2022

Looks like this is a combination of #5883, and #6052. I suggest you split them into individual PRs. That would be easier to review

thank you! i closed the previous pull request [ #5883 ] just now so that it won't hinder the proccess of reviewing.

@ye290329
Copy link

Describe your change:

this algorithm returns a so called 'wave' of a given string [ a list of each of it's capitalized charachters one by one. ]

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

close the repaper

@ye290329
Copy link

leave this attention

@meg-1 meg-1 mentioned this pull request Apr 2, 2022
Closed
14 tasks
@meg-1
Copy link
Contributor Author

meg-1 commented Apr 16, 2022

@Kush1101 could you please review this pull request??

@ghost ghost mentioned this pull request May 7, 2022
Closed
14 tasks
@meg-1
Copy link
Contributor Author

meg-1 commented May 11, 2022

@Kush1101, could you please review this pull request??

@ghost ghost added the tests are failing Do not merge until tests pass label May 12, 2022
@meg-1
Copy link
Contributor Author

meg-1 commented Jun 18, 2022

@Kush1101 could you please check out this pull request?

@ghost ghost removed the tests are failing Do not merge until tests pass label Jun 22, 2022
poyea
poyea reviewed Jun 22, 2022
View reviewed changes
@meg-1 @poyea
merging strings/wave.py
aafe756 
merging the suggestion

Co-authored-by: John Law <[email protected]>
poyea
poyea approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@poyea poyea merged commit 04bc8f0 into TheAlgorithms:master Jun 23, 2022
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Jun 23, 2022
@meg-1 meg-1 deleted the wave branch August 13, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meg-1 @poyea @ye290329