Added 2 new algorythms (decrypt message, censor) #5883

meg-1 · 2021-12-25T12:51:08Z

Describe your change:

Added 2 new algorythms (decrypt message, censor)

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

…ions

IdoErel

The comments are too long.
Keep the comments short and concise.

The code is implementing what's already been implemented in python.

Kind regards,
IdoErel

bayrsaixan · 2021-12-28T06:00:25Z

https://www.easeus.com/backup-software/?utm_source=youtube-heyiran-202107-tb-AsoftClick&utm_medium=referral

…

On Tue, 28 Dec 2021, 08:58 IdoErel, ***@***.***> wrote: ***@***.**** requested changes on this pull request. The comments are too long. Keep the comments short and concise. Kind regards, Ido Erel — Reply to this email directly, view it on GitHub <#5883 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASCQE6XICOYBW3MSNKLOHOTUTEDRRANCNFSM5KXZIB3Q> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

meg-1 · 2022-01-05T14:12:04Z

The code is implementing what's already been implemented in python.

Thank you a lot for the feedback! Quick question, you mean both algorithms have been implemented in Python already, right? Or just the censor algorithm?

amaank404

Thank you for trying but it seems that decrypt does not do any decryption but only removes the character provided to it and does not do any real world decryption. You might say that it does English deobfuscation but that is also false as well (in case you say so).

here is an example, both of them are equivalent, the latter being already inbuilt.

decrypt("o$ne", "$") == "o$ne".replace("$", "")

and for the censor function that is also achieved by the same replace.

censor("bad word", "bad") == "bad word".replace("bad", "***")

Okay, I get it that censor is still reasonable but decrypt is unnecessary.

meg-1 · 2022-01-22T12:34:33Z

Thank you for trying but it seems that decrypt does not do any decryption but only removes the character provided to it and does not do any real world decryption. You might say that it does English deobfuscation but that is also false as well (in case you say so).

here is an example, both of them are equivalent, the latter being already inbuilt.
decrypt("o$ne", "$") == "o$ne".replace("$", "")
and for the censor function that is also achieved by the same replace.
censor("bad word", "bad") == "bad word".replace("bad", "***")
Okay, I get it that censor is still reasonable but decrypt is unnecessary.

Thank you so much for the feedback, it's greately appreciated. Would it be okay if I remove the "decrypt" function, and only set a pull request for the censor function? Or does the censor function not hold any value to the repository, and it's not neccessary to commit?

amaank404 · 2022-01-22T13:17:21Z

As I am not a maintainer, I can only advise yes but please consider mentioning to any of the maintainers. My advise does not help with the merge decision of any PR and is completely up to maintainer

ghost

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

ghost · 2022-01-29T12:57:52Z

maths/average_welford.py

@@ -0,0 +1,21 @@
+def average_welford(values):


Please provide return type hint for the function: average_welford. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide type hint for the parameter: values

amaank404 · 2022-01-31T07:38:12Z

maths/average_welford.py

@@ -0,0 +1,21 @@
+def average_welford(values):


Suggested change

def average_welford(values):

def average_welford(values) -> float:

meg-1 · 2022-03-16T15:14:57Z

@Kush1101 , hello! could you please review this pull request??

maths/average_welford.py

strings/decrypt.py

poyea · 2022-03-24T18:41:36Z

Sometimes the CI is not running - just LMK if that's the case

meg-1 · 2022-03-26T12:47:42Z

Sometimes the CI is not running - just LMK if that's the case

ty, i think that might have been the case. will definitely inform if it happens again!

meg-1 and others added 20 commits May 16, 2021 13:18

Added censor function

00c22a3

Added censor code

4194344

Added comments to the code

e7d4102

modified censor function

93bd4ac

added decrypt function

b714278

added cypher and decypher functions, deleted censor and decrypt funct…

c879c7f

…ions

Deleted decrypt.py

e60dd6f

Deleted censor.py

b3e0cb8

Merge branch 'TheAlgorithms:master' into master

e14b9ef

edited the crypt and decrypt files

947f7d8

Update cypher_txt.py

daf21ad

Remove the endline in cypher.py

d3d8b29

Removed the print at the end of decypher.py

752c197

comitting changes

9f44028

added 4 new algorithms

f72431b

added tests to the four files

4c891f4

added type hints for the function variables

c600b10

Merge branch 'TheAlgorithms:master' into master

4286e40

Deleted decode message

7a909e2

Deleted code message

f5b5411

ghost added the awaiting reviews This PR is ready to be reviewed label Dec 25, 2021

IdoErel suggested changes Dec 28, 2021

View reviewed changes

amaank404 suggested changes Jan 16, 2022

View reviewed changes

Welford average algorithm

bc8388c

meg-1 requested a review from Kush1101 as a code owner January 29, 2022 12:57

ghost added the require type hints https://docs.python.org/3/library/typing.html label Jan 29, 2022

ghost reviewed Jan 29, 2022

View reviewed changes

ghost added the tests are failing Do not merge until tests pass label Jan 30, 2022

amaank404 suggested changes Jan 31, 2022

View reviewed changes

added average welford algorithm

9be479e

ghost removed the require type hints https://docs.python.org/3/library/typing.html label Feb 9, 2022

This was referenced Mar 23, 2022

Max sectors #6059

Closed

Find unique #6060

Closed

poyea reviewed Mar 24, 2022

View reviewed changes

maths/average_welford.py Outdated Show resolved Hide resolved

poyea mentioned this pull request Mar 24, 2022

Wave #6061

Merged

14 tasks

poyea reviewed Mar 24, 2022

View reviewed changes

strings/decrypt.py Outdated Show resolved Hide resolved

meg-1 added 2 commits March 26, 2022 14:53

indentation added

5ebf785

switched print to return in the end

0570692

ghost removed the tests are failing Do not merge until tests pass label Mar 29, 2022

meg-1 closed this Mar 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Added 2 new algorythms (decrypt message, censor) #5883

Added 2 new algorythms (decrypt message, censor) #5883

Uh oh!

meg-1 commented Dec 25, 2021

Uh oh!

IdoErel left a comment •

edited

Loading

Uh oh!

bayrsaixan commented Dec 28, 2021 via email

Uh oh!

meg-1 commented Jan 5, 2022

Uh oh!

amaank404 left a comment •

edited

Loading

Uh oh!

meg-1 commented Jan 22, 2022

Uh oh!

amaank404 commented Jan 22, 2022

Uh oh!

ghost left a comment

Uh oh!

ghost Jan 29, 2022

Uh oh!

amaank404 Jan 31, 2022

Uh oh!

meg-1 commented Mar 16, 2022

Uh oh!

Uh oh!

Uh oh!

poyea commented Mar 24, 2022

Uh oh!

meg-1 commented Mar 26, 2022

Uh oh!

Uh oh!

	def average_welford(values):
	def average_welford(values) -> float:

Uh oh!

Added 2 new algorythms (decrypt message, censor) #5883

Added 2 new algorythms (decrypt message, censor) #5883

Uh oh!

Conversation

meg-1 commented Dec 25, 2021

Describe your change:

Checklist:

Uh oh!

IdoErel left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bayrsaixan commented Dec 28, 2021 via email

Uh oh!

meg-1 commented Jan 5, 2022

Uh oh!

amaank404 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

meg-1 commented Jan 22, 2022

Uh oh!

amaank404 commented Jan 22, 2022

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

ghost Jan 29, 2022

Choose a reason for hiding this comment

Uh oh!

amaank404 Jan 31, 2022

Choose a reason for hiding this comment

Uh oh!

meg-1 commented Mar 16, 2022

Uh oh!

Uh oh!

Uh oh!

poyea commented Mar 24, 2022

Uh oh!

meg-1 commented Mar 26, 2022

Uh oh!

Uh oh!

IdoErel left a comment •

edited

Loading

amaank404 left a comment •

edited

Loading