fix: handle zero case in Armstrong number check to avoid Math.log10(0… #6229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tejaswi1305
requested review from
yanglbme,
vil02,
BamaCharanChhandogi,
alxkm and
siriak
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6229 +/- ##
============================================
- Coverage 73.80% 73.80% -0.01%
Complexity 5311 5311
============================================
Files 673 673
Lines 18376 18378 +2
Branches 3553 3554 +1
============================================
+ Hits 13563 13564 +1
Misses 4265 4265
- Partials 548 549 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DenizAltunkapan
suggested changes
Apr 29, 2025
Comment on lines
+24
to
44
| if (number < 0) { | ||
| return false; // Negative numbers cannot be Armstrong numbers | ||
| } | ||
| if (number == 0) { | ||
| return true; // 0 is an Armstrong number | ||
| } | ||
|
|
||
| while (originalNumber > 0) { | ||
| long digit = originalNumber % 10; | ||
| sum += (long) Math.pow(digit, totalDigits); // The digit raised to the power of total number of digits and added to the sum. | ||
| originalNumber /= 10; | ||
| } | ||
| long sum = 0; | ||
| int totalDigits = (int) Math.log10(number) + 1; | ||
| long originalNumber = number; | ||
|
|
||
| return sum == number; | ||
| while (originalNumber > 0) { | ||
| long digit = originalNumber % 10; | ||
| sum += (long) Math.pow(digit, totalDigits); | ||
| originalNumber /= 10; | ||
| } | ||
|
|
||
| return sum == number; | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
Very thoughtful of you! Nice that you noticed. Please run Clang to format your code, as the pipeline is failing — the rest looks good to me! 😊 @Tejaswi1305
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a safe check for number == 0 in the Armstrong number logic to avoid a Math.log10(0) exception.
Also acknowledges 0 as a valid Armstrong number (since 0^1 = 0).
Why:
Without this, passing 0 causes an ArithmeticException due to log10(0). This PR ensures the code handles all valid inputs correctly.