Skip to content
This repository was archived by the owner on Jun 1, 2023. It is now read-only.

Fix "malloc: Double free of object" #99

Merged
merged 1 commit into from
May 8, 2020
Merged

Conversation

mattt
Copy link
Contributor

@mattt mattt commented May 6, 2020

Possible resolution for #78 and #98, based on @kean's observation about the thread unsafety of Interface.

@mattt
Copy link
Contributor Author

mattt commented May 8, 2020

I can't reliably reproduce the current crash, but I am reasonably sure about the underlying cause and, anecdotally, haven't encountered this after applying this patch. Tests are passing, and there's no significant change to performance, so I think the best approach would be to merge into master and get more eyes on this in the wild.

@mattt mattt merged commit 7c341a9 into master May 8, 2020
@mattt mattt deleted the fix-double-free-crash branch May 8, 2020 16:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant