This repository was archived by the owner on Jun 1, 2023. It is now read-only.
Regression - private subclasses showing #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattt
approved these changes
Jul 27, 2020
|
Hey @MattKiazyk, sorry for not responding sooner. Thank you for submitting this PR! Everything is looking great, and I'm excited to include this as part of Friday's forthcoming release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Private symbols are showing up in pages when they inherit from a public symbol.
I believe this is a regression caused by the refactor in #99. This was working correctly in 1.0-beta.2
The issue is that
symbolsis being used inrelationshipclosure, but instead of using the filtered var, it's using the symbol property that's passed into the init - which is not filtered. This causes private subclasses to show on a parent page. The private page wasn't created, causing a missing link.I went with the easy filter inside the closure option fix.
I also wrote a quick test to hopefully stop any reggressions in the future where any non-public subclasses should never be shown anywhere.